Repository navigation
docs(kms): require admin TLS for onboarding handover - #1558
Merged
Merged
Conversation
Admin.GetKmsKey needs the caller's RA-TLS certificate, which a plain-HTTP admin listener cannot receive: without [core.admin.tls] the call fails with "No attestation provided" and the onboarding client fails to verify the source. Document the source-side admin setup (TLS, a reachable address, the token), fix the onboarding example's port (8001, not the gateway's 9202), and use https in the README admin example that already configures TLS. Signed-off-by: Kevin Wang <wy721@qq.com>
Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboarding through
Admin.GetKmsKeyonly works when the source's admin listener has[core.admin.tls]: on plain HTTP the new KMS cannot present its RA-TLS certificate, so the call fails withNo attestation provided(andOnboard.OnboardwithNo TLS info in response). The docs did not say so, and the defaults (admin off, loopback, TLS commented out) leave operators to discover it from errors.docs/deployment.md: add the source-side admin config (TLS, reachable address, token); fix the onboarding example tohttps://<source-kms>:8001with a required token.dstack/kms/README.md: usehttpsin the admin example that configures TLS; state the onboarding requirements.dstack/kms/kms.toml: note that onboarding needs admin TLS and a reachable address.Verified against
feat/kms-epochs-combined@ba34bd9ewith the #841kms-onboardfixture: without admin TLS all three handover paths fail and no root key is written; with it, the calls pass attestation and token checks.