Skip to content

feat(recall): name the skill a recalled Gene pins, with the command that installs it - #106

Merged
forrestlinfeng merged 4 commits into
EvoMap:mainfrom
Mike-7777777:feat/required-skill-note
Nov 21, 2026
Merged

forrestlinfeng merged 4 commits into
EvoMap:mainfrom
Mike-7777777:feat/required-skill-note

Conversation

@Mike-7777777

@Mike-7777777 Mike-7777777 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Since Evolver 2.0.54 a Gene can pin a skill it needs as one preconditions entry:

skill:git+https://github.com/<owner>/<repo>@<commit>#sha256=<digest>&path=<dir>

evolver skill fetch and the MCP tool evolver_skill_install install it. The plugin injects only a Gene's strategy and gives the model no tools, so a host that runs Evolver through this plugin (ZCode, Codex, Claude Code) never learns the Gene needs a skill. For the game-design demo Genes the strategy is the short version and the skill carries the detail: the interfaces, invariant tables and checks.

Change

When the injected Gene pins skills, the injected text ends with the skill names, the command that installs them and the file to read:

Required skill (pinned by this Gene): quest-prototype-three-round-gate. Before acting, install it and read it:
- Run: evolver skill fetch --asset sha256:9404aec4…9e7e --out .agents --write --force
- Read .agents/skills/quest-prototype-three-round-gate/SKILL.md and follow it with the steps above.
  • lib/required-skills.js reads the pins from preconditions (also under payload / gene) and names each skill the way Evolver installs it: the last segment of path, or of the repository.
  • The lines go into a single strategy (lib/recall.js) and into each Recipe step whose Gene pins a skill (lib/recipe.js). They sit outside the strategy's token cut, so a long strategy never loses them.
  • A Gene that pins a skill needs one strategy step, not four. The four-step floor keeps out Genes too thin to reuse; a pinned Gene keeps its detail in the skill, so a pure-skill Gene, whose two steps point at the skill, is injected as well. Genes without a pin keep the four-step floor.
  • The hook runs nothing and adds no wait. Evolver fetches the pinned commit and checks the digest when the model runs the command. The plugin only builds the command, and only from a sha256:<64 hex> asset id and a pin that has a commit and a digest; anything else names no skill and the strategy is injected as before.
  • .agents/skills is a skill root ZCode and Codex both load, and the text names the file, so any host can read it.

Verified

  • test/required-skills.test.js (new, 9 cases): one pin, a pin at the repository root, two pins, malformed pins and an unsafe asset id, a long strategy cut for length that keeps the skill lines, a Gene without a pin, a Recipe step, a two-step Gene that pins a skill (injected), and a two-step Gene without a pin (still passed over). npm test on this branch: 1209 pass, 10 skipped, 3 fail; the 3 failures are in test/runtime/desktop-engine.test.js and fail the same way on main on this machine.
  • Against production Hub and Proxy 2.0.54, the plugin's own recallStrategy on the live pinned Gene sha256:9404aec4…9e7e injected the text above. Running the injected command unchanged in an empty project with Evolver 2.0.54 installed both SKILL.md files, and .agents/skills/quest-prototype-three-round-gate/SKILL.md is byte-identical to the pinned commit in Mike-7777777/gene-skills.
  • On the pure-skill version of the Case 1 Gene in Mike-7777777/gene-skills (republish/genes/, two strategy steps and the pin), recallStrategy injects both steps followed by the install and read lines.
  • npm run pack built dist/zcode; ZCode 3.18.2 validated, installed and enabled it, and its hooks ran in a ZCode CLI session.

…ommand that installs it

A Gene can pin a skill in preconditions (skill:git+<repo>@<commit>#sha256=<digest>&path=<dir>,
Evolver 2.0.54). The plugin gives the model no tools and injected only the strategy, so a
pinned skill never reached the model. The injected strategy, single or a Recipe step, now
ends with the skill's name, the evolver skill fetch command that installs it under .agents,
and the SKILL.md to read. These lines sit outside the strategy's token cut.
@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。

GitHub CI 未通过。 此状态来自当前 CI gate,不是 Sentinel finding;请以最新 CI attempt 的日志为准。

另有 1 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=106、head_sha="d18b15d77ddac4f073e6f595a1390df9d284b215",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 d18b15d77dda

@evomap-aiqa-bot

Copy link
Copy Markdown

Sentinel 保留了 1 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
开发 agent:请 review 以下 advisory,并逐条给出“已验证无风险 / 已修复 / 转为后续事项”的结论;不要只做整体确认。

  • [P3] Recipe 的聚合文本包含技能要求,但 stepTexts 响应字段仍然丢失技能要求 — 本次变更在 readableStepsOf 中构造 skillLines,但同时生成的 strategyText 仍只有标题和步骤:...(truncated) · lib/recall.js · advisory_204ff0284df7b894e53b3cc3

需要完整证据时,可用行末 finding_key 查询 Sentinel PR review context。

由 Sentinel 审核 · 目标提交 d18b15d77dda

@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。

另有 1 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=106、head_sha="e2fec00086cb6167ec918c90d43ff3705c24a59a",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 e2fec00086cb

@evomap-aiqa-bot

Copy link
Copy Markdown

Sentinel 保留了 1 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
开发 agent:请 review 以下 advisory,并逐条给出“已验证无风险 / 已修复 / 转为后续事项”的结论;不要只做整体确认。

  • [P3] Recipe 的逐步骤返回字段仍丢失必需 Skill 指令 — 本次新增的 skillLines 只被保存到每个 step 对象,并由 recipeTextOf() 拼入聚合的 match.text。...(truncated) · lib/recall.js · advisory_d1e4f93430cdc257526f62ca

需要完整证据时,可用行末 finding_key 查询 Sentinel PR review context。

由 Sentinel 审核 · 目标提交 e2fec00086cb

The four-step floor keeps out Genes too thin to reuse. A Gene that pins a skill
keeps its detail in the skill, so a short strategy that points at it is enough.
@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。

另有 1 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=106、head_sha="90436c76323367540bcbde83320ca1994b8bb648",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 90436c763233

@evomap-aiqa-bot

Copy link
Copy Markdown

Sentinel 保留了 1 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
开发 agent:请 review 以下 advisory,并逐条给出“已验证无风险 / 已修复 / 转为后续事项”的结论;不要只做整体确认。

  • [P3] Recipe 的 stepTexts 仍丢失 pinned Skill 指令 — 当前新增的 skillLines 被保存到 step 对象,但同一行构造的 strategyText 仍只有标题和策略步...(truncated) · lib/recall.js · advisory_a93e6db16d513aae83810cd0

需要完整证据时,可用行末 finding_key 查询 Sentinel PR review context。

由 Sentinel 审核 · 目标提交 90436c763233

The session ledger keeps each Recipe step's own text for the turn's reuse
report and for distillation; it carried the steps but not the pinned skill,
while a single strategy's ledger entry did.
@Mike-7777777

Copy link
Copy Markdown
Contributor Author

三条 advisory 说的是同一件事,逐条结论如下:

  • advisory_204ff0284df7b894e53b3cc3(d18b15d):已修复,见 2874dcf。
  • advisory_d1e4f93430cdc257526f62ca(e2fec00):已修复,同上。
  • advisory_a93e6db16d513aae83810cd0(90436c7):已修复,同上。

原因:组合方案(Recipe)每一步的单独文本 stepTexts 会按 Gene 记进会话的注入台账,回合结束时交给复用上报和经验提炼;之前它只有标题和步骤,没有带上 Gene 钉住的 skill,而单个 Gene 注入时台账里记的是含 skill 说明的完整文本,两条路径不一致。

修法:lib/recall.js 的 readableStepsOf 生成 strategyText 时把 skill 说明接在步骤后面,和注入给模型的 Recipe 文本一致。是否照做的判定只统计带编号的步骤行(lib/applied.js 的 STEP_PREFIX),skill 说明不带编号,判定结果不变。

验证:test/required-skills.test.js 的 Recipe 用例新增两条断言,钉了 skill 的步骤其 stepTexts 含 skill 说明、没钉的步骤不含;修复前失败,修复后通过。npm test:1209 通过、10 跳过、3 失败,3 条失败在 test/runtime/desktop-engine.test.js,在 main 上同样失败。

@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现需要报告的问题。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=106、head_sha="2874dcfb2fb02753f4beb097a39b0a73387eb142",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 2874dcfb2fb0

@forrestlinfeng
forrestlinfeng merged commit 54b7b97 into EvoMap:main Nov 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants