Repository navigation
Conversation
A pull-sync partner's empty source on a row too full to take its UID was looked up on every navigation: the write planner dropped the UID for size, the source stayed empty and the EC ID went to the partner again. Pull sync now reserves the bytes its longest UID adds to a row and treats a source as not due when the row lacks that room, so the partner is not called until pruning frees space. This matches batch sync, which refuses the same row with row_full and is not retried. Closes #1551. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
The edge cookies guide now says pull sync skips a partner whose empty source has no room left on the EC row, matching the design spec and the coordinator. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
This was referenced Nov 20, 2026
3 tasks
dhruv8sh
marked this pull request as ready for review
November 20, 2026 09:12
This was referenced Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
row_fullalready refused full rows without retrying, so the two now match.Changes
crates/trusted-server-core/src/ec/coordinator/mod.rsdue_sourcesreports the source asNotDuewhen the row size plus the reserve exceedsMAX_ENTRY_BYTES. Tests:pull_sync_does_not_recall_a_partner_for_a_full_row,pull_uid_reserve_covers_the_longest_pulled_uid.crates/trusted-server-core/src/ec/write_plan.rsserialized_lenandmember_lenbecomepub(crate)so the coordinator can measure rows.docs/guide/edge-cookies.md,docs/superpowers/specs/2026-10-30-s2s-eid-collection-design.mdKnown limit: the reserve assumes the UID needs no JSON escaping, so a UID made mostly of escaped characters could still be called once and then not fit.
Closes
Closes #1551
Spec
Not a feature (bug fix; follow-up from #1487, design in
docs/superpowers/specs/2026-10-30-s2s-eid-collection-design.md).Test plan
cargo test-fastly && cargo test-axum(alsotest-cloudflare,test-spin)cargo clippy-fastly && cargo clippy-axum(alsoclippy-cloudflare,clippy-spin-native)cargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest run(no JS changes)cd crates/trusted-server-js/lib && npm run format(no JS changes)cargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serveChecklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!)