Repository navigation
Conversation
53edc2f to
117a58e
Compare
jevansnyc
left a comment
There was a problem hiding this comment.
Reviewed the Axum identity lifecycle, process-local KV/CAS behavior, auction wiring, and included SharedID changes. No blocking runtime issues found. One non-blocking documentation correction below. All reported CI checks pass. Local verification: cargo test-axum passed all 73 tests (including all six new identity tests); one documentation example is ignored.
ChristianPavilonis
left a comment
There was a problem hiding this comment.
Summary
Adds server-side identity collection to the Axum dev server with process-local generation-based CAS storage, and updates SharedID defaults and retention. Approved with one non-blocking documentation correction.
Non-blocking
🏕 camp site
- Update contradictory provider documentation — see inline at
docs/guide/configuration.md:926–929.
The inline comment is prose-only because the complete correction spans multiple files and lines outside the diff.
Verification
- Focused configuration-validation scratch probe: PASS.
git diff --check: PASS.- Passing remote CI results reused; full local suites and deployed-runtime testing were not rerun.
CI Status
- integration tests (Fastly EC lifecycle): PASS
- integration tests: PASS
- browser integration tests: PASS
- trace runtime and browser acceptance: PASS
- cargo test (ts CLI, native) (macos-latest): PASS
- cargo test (ts CLI, native) (ubuntu-latest): PASS
- cargo check (cloudflare native + wasm32-unknown-unknown): PASS
- cargo test (cross-adapter parity): PASS
- worker-deadlines (cloudflare): PASS
- cargo test (axum native): PASS
- ts dev lint domains (changed lines): PASS
- cargo check/build/test (spin native + wasm32-wasip1): PASS
- HTML EOF runtime (Fastly): PASS
- CI Node pin guard: PASS
- format-typescript: PASS
- prepare integration artifacts: PASS
- cargo test: PASS
- vitest: PASS
- cargo fmt: PASS
- release scripts: PASS
- CLAUDE.md symlink guard: PASS
- docs-proposal scripts: PASS
- format-docs: PASS
- worker-deadlines (spin): PASS
GitHub reports no required checks for this branch.
Per the user, every feature is built once and works on every adapter in platform order, with platform gaps sent to EdgeZero (DEC-16, SH-5). T21 moves the identity routes, EC lifecycle, providers and write-back into one router in core that each adapter mounts; A2, A10, T8, T9, T17 and T18 shrink to turning it on per adapter and passing the conformance suite, and T7, T14 and A11 fold into A2 and A10. EZI-2a adds EdgeZero's local store for Axum development and EZI-4 binds Axum's geo provider from the manifest. Restack the Axum RC units on #1506: #1531 carries A1 in place of #1528, #1533 and #1534 close as copies of #1525 and #1526, and the image and Terraform units sit directly on #1532 so A6 and A7 stop waiting on A2. Record #1566, refresh the provider stack's fixes at their current heads, and flag #1535 as unplanned.
|
CREATOR: From the server-side identity plan (#1559, Part of #1574 |
117a58e to
3d62f4d
Compare
|
Moved #1566 now holds only the Axum work, at full EC-lifecycle parity with Fastly. The remaining differences (process-local store, UA-only bot gate, detached post-response task) are what T21/EdgeZero replaces, so this stays open until the rebuild on T21. |
The merged identity app opened the record store when the sandbox started, so a missing or failing store turned every route into an assembly error. A lazy store keeps one store per sandbox but opens it on the first EC operation, so only EC work fails. Without an identity graph a withdrawal expires the cookie because no row can exist; drop the redundant failure mark, since the consent-update endpoint already answers 503 without a graph. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Native (Axum) EC persistence now applies the page-load write gate and withdrawal rule, and refuses to start with an enabled provider. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Explicit withdrawal expires the EC cookie and strips identity headers even when a tombstone fails or no identity graph is available; the failure is logged and marks the consent-update response failed. New issuance and orphan recovery retry an ID collision with a fresh ID, up to five Add attempts, inside the navigation's single page-load write, so a page load still writes the row once and the row is still written before the cookie. The page-load permit now follows the shared navigation rule (Sec-Fetch-Dest document with the Accept fallback), so Axum and Fastly mint an EC on the same navigations as before the merge. Restore the affected pre-merge tests. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
… spec Native and Fastly EC follow the shared async EC minting, collision and withdrawal rules from 1566 up, not the page-load gate and withdrawal rule this spec describes for PR A. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
From #1566 up an EC is minted, cookies persist and pull sync runs on any browser document navigation (Sec-Fetch-Dest: document, or an Accept header naming text/html without Fetch Metadata), an ID collision retries inside the navigation's one write, and an explicit withdrawal expires ts-ec even when its tombstone fails. The edge cookies guide still described the Fetch Metadata-only rule and the kept cookie. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
3d62f4d to
32d83a9
Compare
The workspace pins EdgeZero by rev, so the job's tag-only lookup failed. A full commit SHA is as immutable as a tag; branches are still rejected. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
The native EC stack wires the Axum EC lifecycle, identify and partner registry directly, as Fastly does. List them as pending lifecycle moves so the guard tracks them until the core identity app owns those routes. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Summary
ts-eccookie (and a consent update reports 503); new and recovered EC IDs get up to five collision attempts, all inside the single page-load write; an EC is minted on any document navigation (Sec-Fetch-Dest: document, with theAcceptfallback).ec.storage, and opens it on the first EC operation rather than at sandbox start.This replaces the earlier content of this PR (an in-memory Axum
ec_kv.rsand Axum identity providers). Providers on Axum are tracked in #1581.Changes
9d02d7b3for all crates (celld added); geo-kv; Axum grants the navigation permit and mints only for permitted browser navigations; startup runs bothec.storageresolution and the enabled-provider check.crates/trusted-server-adapter-fastly/src/app.rs,ec_record_store.rs,main.rsec.storage(legacyec_storestill works) and opened lazily;configuredeclarestrusted_server_kv; tests use the registry-aware EdgeZero test runner.crates/trusted-server-core/src/ec/finalize.rs,ec/kv.rs,ec/page_load.rs,ec/consent_update.rscrates/trusted-server-adapter-axum/src/app.rs,tests/native_ec.rsdocs/superpowers/specs/2026-10-30-s2s-eid-collection-design.md,docs/guide/edge-cookies.mdCloses
Refs #1567. Sits on #1540 (Christian's stack); #1624 stacks on top.
Spec
Christian's design docs:
docs/superpowers/specs/2026-11-10-shared-async-ec-design.md,docs/superpowers/specs/2026-11-03-ec-storage-provider-configuration-design.md,docs/guide/native-ec-persistence.md; ours:docs/superpowers/specs/2026-10-30-s2s-eid-collection-design.md.Test plan
cargo test-fastly && cargo test-axum(alsotest-fastly-reuse,test-cloudflare,test-spin, parity, build-digest, CLI tests)cargo clippy-fastly && cargo clippy-axum(all clippy aliases)cargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1scripts/smoke-axum.shandscripts/smoke-fastly.sh(Viceroy) passscripts/lint-wasm-clock.shChecklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!)