Repository navigation
fix(docker): install the issue-worker review tools as wheels only - #133
Merged
Merged
Conversation
The second pip install in IssueWorker.Containerfile took sdists too, so a setup script could run during the image build (SonarCloud docker:S8541). All four tools and their dependencies ship wheels for Python 3.11.
Up to standards ✅🟢 Issues
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8,bandit,mypy,playwright) as wheels only.docker/IssueWorker.Containerfilenow passes--only-binary :all:to thatpip install, as the hash-lockedci.txtinstall above it already does, so no setup script runs while the image is built (SonarCloud docker:S8541 on PR Merge dev into main #132).pip download --only-binary :all:for Python 3.11 on manylinux x86_64 resolves all four and their dependencies (21 wheels, no source distribution).docker/IssueWorker.Containerfile.Unblocks the dev → main merge (#132): this is the one SonarCloud vulnerability there that is a real finding.