Repository navigation
Support Adapt and copy for WaveletOp - #62
Merged
nHackel merged 2 commits intoNov 13, 2026
Merged
Conversation
WaveletOp now returns a WaveletOpImpl that keeps the shape without singleton dimensions, the wavelet and the host arrays of the transform. Adapt.adapt and copy rebuild the operator, its closures and host arrays from the shape and wavelet with the target storage type. The transform still runs on the CPU; non-Vector storage copies input and output through the host arrays, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Adapt and copy checks move into testWaveletAdapt with an element-type argument. testWavelet calls it with Float64 as before, and test/gpu/metal.jl loads the testOperators.jl helpers and calls it with Float32. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 84.01% 84.25% +0.24%
==========================================
Files 16 16
Lines 713 724 +11
==========================================
+ Hits 599 610 +11
Misses 114 114 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nHackel
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WaveletOpnow returns aWaveletOpImplthat keeps the shape, the wavelet and the host arrays of the transform.Adapt.adaptandcopyrebuild it for the target storage, likeSamplingOpandGradientOp.WaveletOpwith this note.testWaveletAdaptadapts an operator with a non-default wavelet and a singleton dimension to the test backend and back, and compares the results with the CPU operator.testWaveletruns it in Float64; the Metal job runs it in Float32.