Repository navigation
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
force-pushed
the
image-segment-ownership
branch
3 times, most recently
from
November 8, 2026 15:45
e9505e6 to
bf32699
Compare
PaulHax
force-pushed
the
image-segment-ownership
branch
2 times, most recently
from
November 13, 2026 00:56
04f913d to
e22fc5c
Compare
PaulHax
force-pushed
the
image-segment-ownership
branch
from
November 14, 2026 21:12
e22fc5c to
32da1d9
Compare
Collaborator
Author
|
Folded into #1035, which carries this commit unchanged as its first commit along with the segment model simplification built on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting or renaming a segment while viewing one base image also changed every other image, because all images shared one segment catalog. Each image now owns its segment definitions, order and selection, shared by Paint, rectangles, polygons and rulers on that image.
The goals are:
“Matched segmentation files” means labelmaps associated with the primary image chosen for the initial load: filename matches such as
scan.seg.nii.gzorscan.seg.nrrdforscan.nrrd(thesegmarker is configurable), or DICOM SEG volumes from the same study. File format alone does not establish the association. See the matching path.Matching names does not merge or overwrite existing voxels. Labelmap import reuses an exact-name segment only if it has no mask; session restore requires no mask or shape. Otherwise the incoming segment gets a numbered name such as
Tumor (2). Configs deliberately reapply names and appearance; removing a config entry only deletes a row that the config created and that has no mask or shape. See segment matching and configuration behavior.One consequence of merging: a session loaded onto an image that is already open keeps that image's existing empty segments beside the restored ones.
Processing results and image removal are scoped to their destination images. Manifest 8.0.0 saves per-image membership, order, selection and defaults, and the migration splits older shared catalogs into independent per-image sets without duplicating voxels. When an older manifest's per-file datasets resolve to one image, the copies of each legacy definition resolve to one segment on that image.
This replaces #1005 with the same per-image model but without deferred initialization or a loading state.