Skip to content

OpenConceptLab/ocl_issues#2885 | Name the feature "AutoMatch" in every language - #94

Merged
paynejd merged 2 commits into
mainfrom
OpenConceptLab/ocl_issues#2885-automatch
Oct 8, 2026
Merged

paynejd merged 2 commits into
mainfrom
OpenConceptLab/ocl_issues#2885-automatch

Conversation

@paynejd

@paynejd paynejd commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Part of OpenConceptLab/ocl_issues#2885 (Mapper side).

Decision (Jon, 2026-10-07, for now): the feature is AutoMatch, one word and never translated, in en, es, zh and pt-BR.

  • Every catalog string that names the feature now says AutoMatch. It replaces "Auto Match", "Coincidencia Automática", 自动匹配 and the pt-BR "Auto Match".
  • The auto_matched state reads "AutoMatched" in en, "Con AutoMatch" in es, "Com AutoMatch" in pt-BR and "已通过 AutoMatch 匹配" in zh.
  • Catalogs only. Keys, placeholders, code identifiers and API values are unchanged.
  • Recorded in the Localization guide glossary.

🤖 Generated with Claude Code

paynejd and others added 2 commits October 7, 2026 16:07
…y language (en, es, zh, pt-BR)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ch" (display only; stored actions unchanged)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@paynejd

paynejd commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Codex review, pass 1 (codex-cli 0.161.0, commit a97fc25)

Verdict: 1 finding.

  • F1.1 (P1) Project history still shows "Auto Match Started" and "Auto Matched" via startCase. Fixed in b31fe63: a display-only transform in ProjectLogs.jsx and Discuss.jsx; stored action ids are unchanged.
findings.json
{
  "reviewer": "codex-cli 0.161.0",
  "perspective": "defects",
  "mode": "full",
  "commit": "a97fc25",
  "verdict": "findings",
  "prior": [],
  "findings": [
    {
      "id": "F1.1",
      "severity": "P1",
      "tag": null,
      "file": "src/components/map-projects/ProjectLogs.jsx",
      "line": 95,
      "claim": "Project and row history still display the old spaced feature name.",
      "scenario": "After running AutoMatch, project history renders auto_match_started and auto_match_finished through startCase as “Auto Match Started” and “Auto Match Finished”. Discuss.jsx:46 similarly renders auto-matched as “Auto Matched”. Both components' tooltips also use startCase, so these user-visible labels bypass the updated catalogs in every language.",
      "action": "Update titles and tooltips in ProjectLogs.jsx and Discuss.jsx to display AutoMatch and the localized auto_matched label, including fallback project actions. Preserve the stored action identifiers.",
      "lines_delta": null,
      "confidence": "high"
    }
  ]
}

@paynejd

paynejd commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Codex review, pass 2 (codex-cli 0.161.0, commit b31fe63)

Verdict: clean. F1.1 is resolved, and the fix broke nothing else.

findings.json
{
  "reviewer": "codex-cli 0.161.0",
  "perspective": "defects",
  "mode": "verify",
  "commit": "b31fe63",
  "verdict": "clean",
  "prior": [
    {
      "id": "F1.1",
      "status": "resolved"
    }
  ],
  "findings": []
}

@paynejd

paynejd commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Simplification review (codex-cli 0.161.0, commit b31fe63)

Verdict: clean. Nothing to cut. The other two #2885 PRs (oclweb3#62, ocl-design-system#15) change only catalogs or docs, so they have no code to simplify.

@paynejd
paynejd merged commit ccdf653 into main Oct 8, 2026
2 checks passed
@paynejd
paynejd deleted the OpenConceptLab/ocl_issues#2885-automatch branch October 8, 2026 12:15
filiperochalopes pushed a commit to filiperochalopes/oclmap that referenced this pull request Oct 19, 2026
…dded

oclmap#93 (ocl_issues#2865) merged the same morning as oclmap#94 and added
strings that still said "Auto Match" or 自动匹配, which OpenConceptLab#94's branch never
saw: the rate-limit notices in en, es, zh and pt-BR, and six pt-BR notices
(throttled rows, no algorithms, blocked runs, nothing to run).

closes OpenConceptLab/ocl_issues#2885

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants