Repository navigation
Conversation
ubuntu-latest is now Ubuntu 26.04, which has no Python 3.9 build for actions/setup-python. The 3.9 job fails and fail-fast cancels the rest of the matrix, so every PR shows red. requires-python is unchanged. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14'] | ||
| python-version: ['3.10', '3.11', '3.12', '3.13', '3.14'] |
There was a problem hiding this comment.
Should fix: Dropping 3.9 from the whole matrix leaves a version you still advertise with no tests at all. pyproject.toml keeps requires-python = ">=3.9" and the 3.9 classifier, and abi3-py39 ships wheels for 3.9. Code that uses 3.10+ syntax or stdlib (e.g. match, X | Y at runtime, zip(strict=)) would merge green and break 3.9 installs. Only ubuntu-latest lacks 3.9; Windows and macOS runners still have it. Keep coverage with a targeted exclude:
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
exclude:
- os: ubuntu-latest
python-version: '3.9'If you can't do that, raise requires-python to >=3.10 and drop the 3.9 classifier.
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14'] | ||
| python-version: ['3.10', '3.11', '3.12', '3.13', '3.14'] |
There was a problem hiding this comment.
Nit: The CI matrix table at AGENTS.md:218 still lists {3.9, 3.10, …, 3.14} for Code Quality, so it no longer matches this workflow. Update it in this PR so the doc matches the matrix.
|
Claude review · advisory Reviewed Open: 0 blocking · 1 should-fix · 1 nit. ❌ Address or reply to the open threads. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
Fixes: no tracking issue; CI on mainline is failing (example run: https://github.com/OpenJobDescription/openjd-model-for-python/actions/runs/42066663793).
What was the problem/requirement? (What/Why)
ubuntu-latestnow resolves to Ubuntu 26.04, which has no Python 3.9 foractions/setup-python("The version '3.9' ... was not found for Ubuntu 26.04"). The 3.9 job fails and fail-fast cancels the rest of the matrix.What was the solution? (How)
Drop 3.9 from the CI matrix in
code_quality.yml, the same change aws-deadline/deadline-cloud-worker-agent made in #1130. The matrix lives in this repo's caller workflow, so no change to the shared reusable workflow is needed.What is the impact of this change?
CI no longer tests Python 3.9.
requires-pythonstays>=3.9; worker-agent #1130 also raised it to>=3.10, which is a separate maintainer decision for this package.How was this change tested?
actionlintpasses on the changed workflow(s); this PR's own CI run is the functional test.Was this change documented?
N/A, CI-only.
Is this a breaking change?
No.
Does this change impact security?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.