Repository navigation
Conversation
|
Test on Playground |
✅ Code Coverage Report
🎉 Great job maintaining/improving code coverage! 📊 File-level Coverage Changes (17 files)🆕 New Files
📈 Coverage Improved
📉 Coverage Decreased
ℹ️ About this report
|
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
103 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
📁 classes/suggested-tasks/providers/class-content-review.php (4 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
232 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
377 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
381 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
388 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
📁 classes/activities/class-query.php (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
71 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58. |
163 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153. |
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
108 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106. |
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
111 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98. |
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
120 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wp_kses lowercased viewBox, which an XML data URI ignores, and dropped gradients, clip paths, rgb() colors and accessibility attributes. Parse the icon with DOMDocument against an allowlist instead: no scripts, styles, event handlers or href, and paint values limited to colors or url(#local-id). Results are cached per request, and an unusable icon falls back to the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Running wp_kses_post on every lesson string HTML-encoded "&" in names, IDs and headings, which then showed up literally and was saved into page-type terms. Only the text and todo_description fields carry markup; every other string is now sanitized as plain text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every lesson video is a Cloudflare Stream iframe (customer-*.cloudflarestream.com), which was not on the host allowlist, so its src was removed. Its style, allow and loading attributes were also stripped, breaking the layout. Allow the Cloudflare Stream host and those attributes; the sandbox stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lessons were re-sanitized on every cache read, and Page_Types reads them on every init. Sanitize the remote response once before caching it. The cache key now carries a version, so entries cached before sanitizing are never read and are fetched again once. The tests use the class's own key instead of rebuilding it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A nonce is tied to the user and session and expires, so it cannot be put in a shared or bookmarked preview link, and nothing generated one. The onboarding risk it guarded against is already closed by get_branding_id( false ) in Base::init(); the preview stays limited to administrators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wp_safe_remote_* rejects loopback and private hosts and ports other than 80/443/8080, so a local PROGRESS_PLANNER_REMOTE_SERVER_ROOT_URL or branding server stopped working. Both URLs are hardcoded or set in wp-config.php, and branding fetches are pinned to the configured server's scheme and host, so use wp_remote_* with redirects still disabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rrors The only caller runs the onboarding request when the site has no license key, so the Authorization header was never sent. Remove it and its test. The server now refuses re-onboarding without the existing key, and the welcome screen only logged that to the console; show the server's message instead and let the user submit again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review follow-up: I pushed fixes directly to this branch, one commit per finding.
Checked: the full PHPUnit suite passes, and phpcs, PHPStan and lint are clean. In the browser I checked the brand preview and icon, a lesson video playing in the editor, and the welcome-screen error. Moving the token from |
Statistics and task requests now require an
Authorization: Bearer <site-token>header; URL credentials no longer grant access. This PR also restricts recommendation and page-type access and sanitizes remote lesson and branding content.Resulting behavior
textandtodo_descriptionretain filtered HTML. Video embeds retain sandboxing and allowlisted HTTPS player hosts, including Cloudflare Stream subdomains.Validation
All 10 GitHub Actions workflows pass on
5c14d143, including PHPUnit/integration tests, PHPStan, code style, lint, security, Plugin Check, coverage, Playwright and update/compatibility tests. Plugin Check reports warnings but no errors.Filip reports browser verification of branding previews/icons, lesson video playback and welcome-screen errors. The review follow-up was checked against the current source. A local merge-tree check against
developatea00838bcompletes without conflicts. No runtime changes were needed for this reconciliation.Coordinated rollout
Companion server change: ProgressPlanner/progress-planner-server#68.
Existing sites need a compatibility plugin that accepts both URL credentials and the selected header before the server switches transport; the strict header-only plugin follows. Deployment and existing-key rotation are separate work.
Stacked PR #803 replaces the bearer header with
X-Progress-Planner-Tokento avoid interference from bearer-auth plugins. It must be coordinated with ProgressPlanner/progress-planner-server#69, and the compatibility stage must support that custom header if the pair is adopted. The custom-header change is not part of this PR.