Repository navigation
Conversation
Pushes the workspaces-backend to the app service on push
…push Update push-docker-image.yml
added other step for building the environment
…push Update push-docker-image.yml
v3 deployment
…push Update push-docker-image.yml
…push Update push-docker-image.yml
name check
…push Update push-docker-image.yml
Lists the workspace's current elements with a non-empty fixme tag (the key in any case, e.g. FIXME), newest first, each with its note, version, changeset, timestamp, tags and a location: a node's own, or the middle of a way's nodes (none for a relation). The OSM API can't search by tag, so, like the bbox and adiff endpoints, this reads the workspace's tables directly. Anyone who can open the workspace can call it. Checked against a real Postgres with the OSM current_* tables: nodes, ways and relations are found, empty notes and deleted elements aren't. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
* Implement workspace creation permissions based on TDEI roles and update tests * Implement TDEI dataset fetching and workspace creation validation based on dataset status and project group * Implement workspace creation permission checks and related API endpoint * Rename TDEI client variable for consistency in security and test files * Add TDEI API backend URL and enhance dataset handling in workspace creation - Introduced TDEI_API_BACKEND_URL in .env.example and docker-compose.local.yml for environment configuration. - Added same_uuid function to compare UUIDs in a case-insensitive manner. - Enhanced TdeiDataset class to include data_type and added matches_type method for workspace type validation. - Updated fetch_tdei_dataset to handle dataset type and improved error handling for TDEI API responses. - Modified WorkspaceRepository to enforce dataset type restrictions during workspace creation. - Expanded integration and unit tests to cover new dataset type validations and TDEI API error scenarios. * Document the workspace creation rule in CLAUDE.md Who may create a workspace (POC, or the data generator of the matching type), the extra checks when creating from a TDEI dataset, and that tdei-admin gets no extra rights. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Normalize TDEI project group role names Trim and lowercase the roles TDEI returns so "POC" or " poc " grant the same rights as "poc", as the frontend's hasCreationRole already does. Roles the backend doesn't model (e.g. tdei-admin) are dropped; they granted nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Require TDEI_API_BACKEND_URL with no default A dev default would quietly send prod tokens to api-dev.tdei.us when a deployment doesn't set it. Fail at startup instead, including for the empty string docker-compose passes when the variable is unset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Jeff Maki <hello@jeffmaki.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
GET /workspaces/{id}/fixmes, which the frontend's review queue calls, and limits workspace creation by TDEI role. Merge before the frontend's Develop to Stage PR.Before deploying: staging must set
TDEI_API_BACKEND_URL=https://api-stage.tdei.us/api/v1/. It is now required and has no default, so the app won't start without it. It must point at the same TDEI environment asTDEI_BACKEND_URL. (Already set on the Azure hosts.)Workspace creation is now role-gated (#147):
tdei-adminon its own) get a 403.POST /workspaces/check-create: the frontend calls this pre-check (workspaces-frontend#174) and shows the reason when creation isn't allowed.Includes:
🤖 Generated with Claude Code