Skip to content

Plugins: List the secrets.php drop-in on the Plugins screen and in Site Health - #14848

Open
mpeshev wants to merge 2 commits into
WordPress:trunkfrom
mpeshev:secrets-dropin-listed
Open

mpeshev wants to merge 2 commits into
WordPress:trunkfrom
mpeshev:secrets-dropin-listed

Conversation

@mpeshev

@mpeshev mpeshev commented Oct 25, 2026 •

Copy link
Copy Markdown

wp-content/secrets.php is loaded on every request since [64337], like object-cache.php, and can replace how every stored credential is protected, but it was missing from _get_dropins(). Neither the Drop-ins view of the Plugins screen nor the Drop-ins section of Site Health Info showed it.

Trac ticket: https://core.trac.wordpress.org/ticket/66380

Testing

  • vendor/bin/phpunit --filter test_get_dropins_includes_secrets_dropin fails without the patch and passes with it.
  • vendor/bin/phpunit --filter Tests_Admin_IncludesPlugin passes (65 tests).

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: finding the issue, drafting the fix and test, and running them. I reviewed every line.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

…Site Health.

`wp-content/secrets.php` is loaded on every request since [64337], like `object-cache.php`, and can replace how every stored credential is protected. It was missing from `_get_dropins()`, so neither the Drop-ins view of the Plugins screen nor the Drop-ins section of Site Health Info showed it.

Follow-up to [64337].

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

See #66380.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mpeshev
mpeshev marked this pull request as ready for review October 25, 2026 18:05
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nofearinc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant