Skip to content

Plugins: List the secrets.php drop-in on the Plugins screen and in Site Health #14848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpeshev wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Plugins: List the secrets.php drop-in on the Plugins screen and in Site Health #14848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd1993
Plugins: List the `secrets.php` drop-in on the Plugins screen and in …
mpeshev Oct 25, 2026
e30b662
Tests: Reference #66380 in the new tests.
mpeshev Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/wp-admin/includes/plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,7 @@ function get_dropins() {
* Includes Multisite drop-ins only when is_multisite()
*
* @since 3.0.0
* @since 7.2.0 Added the `secrets.php` drop-in.
*
* @return array[] {
* Key is file name. The value is an array of data about the drop-in.
Expand All @@ -507,6 +508,7 @@ function _get_dropins() {
'object-cache.php' => array( __( 'External object cache.' ), true ), // Auto on load.
'php-error.php' => array( __( 'Custom PHP error message.' ), true ), // Auto on error.
'fatal-error-handler.php' => array( __( 'Custom PHP fatal error handler.' ), true ), // Auto on error.
'secrets.php' => array( __( 'Custom Secrets API backend.' ), true ), // Auto on load.
);

if ( is_multisite() ) {
Expand Down
20 changes: 20 additions & 0 deletions tests/phpunit/tests/admin/includesPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,26 @@ public function test_get_dropins_not_empty() {
$this->_restore_drop_ins();
}

/**
* @ticket 66380
*
* @covers ::get_dropins
*/
public function test_get_dropins_includes_secrets_dropin() {
$this->_back_up_drop_ins();

$p1 = $this->_create_plugin( "<?php\n//Test", 'secrets.php', WP_CONTENT_DIR );

$dropins = get_dropins();

unlink( $p1[1] );

$this->assertSame( array( 'secrets.php' ), array_keys( $dropins ) );

// Clean up.
$this->_restore_drop_ins();
}

/**
* @covers ::is_network_only_plugin
*/
Expand Down
Loading