[shail-mehta]

Part of: #64895

What

Replaces the remaining assertNotEquals() call in tests/phpunit/tests/media.php with assertNotSame() for the prepared attachment URL check.

Updated method:

• test_wp_prepare_attachment_for_js(): assertNotEquals( '', $prepped['url'] ) → assertNotSame( '', $prepped['url'] )

Why

#64895 asks for strict assertions when both sides share a type. The prepared attachment url is a string, so assertNotSame() is appropriate.

How

• Convert the empty-string URL inequality check from assertNotEquals() to assertNotSame()
• Leave other assertions in the file unchanged

Testing instructions

1. Start the local WordPress develop environment.
2. Run: npm run test:php -- --filter test_wp_prepare_attachment_for_js

Use of AI tools

Cursor

[Copilot]

🟢 Approval recommended

The one-line change matches the URL’s string contract and preserves the intended non-empty check.

No open issues 🎉

What changed in this PR

Updates the attachment URL test to use a strict assertion, supporting the assertion cleanup in WordPress ticket #64895.

Changes:

• Replaces assertNotEquals() with assertNotSame() for the empty-string URL comparison.
• Leaves all other assertions unchanged.

File	Description
tests/​phpunit/​tests/​media.php	Uses strict inequality for the prepared attachment URL check.

_{Review effort: Balanced}

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[Copilot]

🟢 Approval recommended

The narrow assertion change matches the string-valued URL contract and introduces no identified correctness issues.

No open issues 🎉

_{Review effort: Balanced}

[lancewillett]

The prepared URL passes through esc_url_raw(), so the empty-string comparison preserves the existing check for this attachment fixture.

Unit-tests audit completed. Combined randomized runs passed: single-site 497 tests / 1,609 assertions; multisite 521 tests / 1,694 assertions, with one skip in each run. PHPCS and CI passed. Copilot has no open findings.

_{AI review · gpt-6}

[mukeshpanchal27]

Committed at r64782