Skip to content

Tests: Use assertNotSame() for attachment JS URL comparison. #14854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shail-mehta wants to merge 1 commit into from
Closed

Tests: Use assertNotSame() for attachment JS URL comparison. #14854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/phpunit/tests/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@
$this->assertSame( '', $prepped['type'] );
$this->assertSame( '', $prepped['subtype'] );
// #21963, there will be a GUID always, so there will be a URL.
$this->assertNotEquals( '', $prepped['url'] );
$this->assertNotSame( '', $prepped['url'] );
$this->assertSame( site_url( 'wp-includes/images/media/default.svg' ), $prepped['icon'] );

// Fake a mime.
Expand Down Expand Up @@ -2377,7 +2377,7 @@
* @ticket 33641
* @requires function imagejpeg
*/
public function test_wp_calculate_image_srcset_no_date_uploads() {

Check warning on line 2380 in tests/phpunit/tests/media.php

View workflow job for this annotation

GitHub Actions / PHP 8.5 / MySQL 8.4 (test reporting enabled)

Slow PHPUnit test 

Tests_Media::test_wp_calculate_image_srcset_no_date_uploads took 1.166679s
$_wp_additional_image_sizes = wp_get_additional_image_sizes();

// Disable date organized uploads.
Expand Down Expand Up @@ -6165,7 +6165,7 @@
*
* @ticket 56442
*/
public function test_quality_with_image_conversion_file_sizes() {

Check warning on line 6168 in tests/phpunit/tests/media.php

View workflow job for this annotation

GitHub Actions / PHP 8.5 / MySQL 8.4 (test reporting enabled)

Slow PHPUnit test 

Tests_Media::test_quality_with_image_conversion_file_sizes took 3.056506s
add_filter( 'image_editor_output_format', array( $this, 'image_editor_output_jpeg' ) );
$temp_dir = get_temp_dir();
$file = $temp_dir . '/33772.jpg';
Expand Down
Loading