Repository navigation
Hkrma nccl ras settings - #480
Merged
Merged
Conversation
added 2 commits
November 11, 2026 04:32
The agent's NCCL RAS job monitor takes each job's endpoints from the pod IPs of its training pods. It never reads ncclRas.nodes, autoDiscover or nodeSelector, and it does not use retryDelay or outputDir, so setting them had no effect. Remove them from the values and the Deployment env. maxRetries is the number of connection attempts per endpoint in each monitoring cycle; the comment now says so. Older agent images read the removed env vars with the same defaults the chart set, so their behavior does not change.
…327.0 The new image fixes the job-level NCCL RAS state, which was always no_data, and stops querying the training operator's pod-manager pods as NCCL RAS endpoints.
Collaborator
|
LGTM |
papriwal
approved these changes
Nov 16, 2026
jam-jee
approved these changes
Nov 16, 2026
1 of 3 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Follow-up to #479 for the
hyperpod-kubernetes-resource-monitorsubchart. The subchart stays disabled by default.image.tag:1.0.498.0_1.0.325.0->1.0.508.0_1.0.327.0. The new agent image:healthy,degraded,unhealthy) from each monitoring cycle<job>-podmanagers-0) as NCCL RAS endpointsmonitoring.ncclRas.nodes,autoDiscover,nodeSelector,retryDelayandoutputDir, and theirNCCL_RAS_*env vars.Before/After UX
Before:
With the subchart enabled, the agent image is
1.0.498.0_1.0.325.0;After:
With the subchart enabled, the agent image is
1.0.508.0_1.0.327.0; the job-level NCCL RAS state reflects the endpoints. The five values are gone; a values file that still sets them renders the same chart (Helm ignores unused values).How was this change tested?
helm dependency update+helm lint HyperPodHelmChart, subchart off and on: 0 failed.helm template(default): 0 objects from the subchart.helm template --set hyperpod-kubernetes-resource-monitor.enabled=true --set hyperpod-kubernetes-resource-monitor.region=ca-central-1: image843976229209.dkr.ecr.ca-central-1.amazonaws.com/hyper pod-cluster-monitoring-agent:1.0.508.0_1.0.327.0; NCCL RAS env isNCCL_RAS_PORT,NCCL_RAS_TIMEOUT,NCCL_RAS_MAX_RETRIES,NCCL_RAS_MONITOR_INTERVALonly./healthz/readyz/health200,HyperPodKRMAConfigstatus Healthy; a 2-node, 16-GPU HyperPodPyTorchJob with
NCCL_RAS_ADDRset to the pod IP reported job-level NCCL RAS statehealthywith 2 endpoints (pod-manager pod skipped).helm template --set hyperpod-kubernetes-resource-monitor.enabled=true --set hyperpod-kubernetes-resource-monitor.region=ap-southeast-3: image971422672635.dkr.ecr.ap-southeast-3.amazonaws.com/h yperpod-cluster-monitoring-agent:1.0.508.0_1.0.327.0.Are unit tests added?
No. Helm chart only; no Python code changes.
Are integration tests added?
No
Reviewer Guidelines
One of the following must be true: