Repository navigation
test(proxy): cover the by-spec open that names no platform or lease backend - #4044
Conversation
…ackend Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Size Report
Startup median (7 runs, lower is better):
|
|
The code looks good at 2918ec1. The new test covers the by-spec open that names no platform or lease backend, and from reading the code it would fail if the refusal were removed. CI is green, with all 18 checks passing, and there are no conflicts. I did not run the test or a mutation that removes the refusal, and I only read connection-runtime.ts around lines 335-349 for other INVALID_ARGS throws on this route. Not blocking: the matcher at https://github.com/callstack/agent-device/blob/2918ec1/src/cli/commands/__tests__/proxy-lease-device-spec.test.ts#L116 is only |
Cover the by-spec open that names no platform or lease backend
Follow-up to #3865. It merged at 576fd1a, before this test was pushed.
Problem
CI's changed-line coverage report for #3865 listed
src/cli/commands/proxy-lease-device.ts:64as uncovered. That is the refusal for anopenthat names a device spec (--os,--image-tagor--physical) without--platformor--lease-backend, so the proxy backend would not know which device family to pick from.Change
proxy-lease-device-spec.test.tsgets one test:open --os 26through a proxy connection with no platform fails withINVALID_ARGSbefore any allocate or device listing. Test-only.Validation
INVALID_ARGS.pnpm check:affected --run --head 2918ec1769passed withexactCommit=true.🤖 Generated with Claude Code