Skip to content

test(proxy): cover the by-spec open that names no platform or lease backend #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Oct 29, 2026
Merged

test(proxy): cover the by-spec open that names no platform or lease backend #4044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/cli/commands/__tests__/proxy-lease-device-spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,25 @@ test('proxy open by device spec sends the spec on allocate without listing devic
fs.rmSync(tempRoot, { recursive: true, force: true });
});

test('proxy open by device spec without a platform or lease backend fails before allocating', async () => {
const { tempRoot, flags } = proxyWorkspace('agent-device-proxy-device-spec-no-platform-');
const { platform: _platform, ...flagsWithoutPlatform } = flags;

await assert.rejects(
materializeRemoteConnectionForCommand({
host: createTestHostEnvironment(),
command: 'open',
flags: { ...flagsWithoutPlatform, osVersion: '26' },
client: createTestClient({
listDevices: unexpectedCommandCall,
allocate: unexpectedCommandCall,
}),
}),
{ code: 'INVALID_ARGS' },
);
fs.rmSync(tempRoot, { recursive: true, force: true });
});

test('a lease returned without lease.device for a spec request is released and the command fails with device-spec-unsupported', async () => {
const { tempRoot, stateDir, flags } = proxyWorkspace('agent-device-proxy-device-spec-noecho-');
const releases: LeaseReleaseRequest[] = [];
Expand Down
Loading