Repository navigation
bundle: read and edit the typed config in five mutators - #7145
Merged
Merged
Conversation
Contributor
|
Commit: Regression test reportSelected 8 changed tests (limit=20, 0 not selected) 16 tests: regression=2 unreleased=0 coverage=14 failing=0
TestAccept/bundle/validate/secret_scope_invalid_permission_level/DMS=: branch ✅ | main (35ed095) ❌ | latest (v1.22.1) ❌main (35ed095): latest (v1.22.1): same output as main (35ed095) TestAccept/bundle/validate/secret_scope_invalid_permission_level/DMS=true: branch ✅ | main (35ed095) ❌ | latest (v1.22.1) ❌main (35ed095): latest (v1.22.1): same output as main (35ed095) |
Collaborator
Integration test reportCommit: 9092e61
Top 6 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/typed-mutators-simple
branch
from
October 21, 2026 15:50
6218b4b to
bd00f2a
Compare
denik
force-pushed
the
denik/typed-mutators-simple
branch
2 times, most recently
from
October 22, 2026 09:40
cd53363 to
6e0b1a9
Compare
denik
force-pushed
the
denik/typed-mutators-simple
branch
from
October 22, 2026 09:54
6e0b1a9 to
26b7cc4
Compare
denik
force-pushed
the
denik/typed-mutators-simple
branch
3 times, most recently
from
October 27, 2026 12:12
911fb1b to
a279053
Compare
denik
force-pushed
the
denik/typed-mutators-simple
branch
from
October 27, 2026 13:00
a279053 to
9a36648
Compare
denik
force-pushed
the
denik/typed-mutators-simple
branch
from
October 27, 2026 17:17
9a36648 to
5a264c3
Compare
denik
force-pushed
the
denik/typed-mutators-simple
branch
2 times, most recently
from
October 27, 2026 20:35
213f547 to
083e679
Compare
denik
force-pushed
the
denik/typed-mutators-simple
branch
2 times, most recently
from
October 28, 2026 13:14
4863c47 to
284e826
Compare
…ld edge cases Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…ss, and show has_queue
…rence and a referenced name
…; say what is broken
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/typed-mutators-simple
branch
from
October 28, 2026 13:34
284e826 to
9092e61
Compare
denik
marked this pull request as ready for review
October 28, 2026 14:14
denik
enabled stacked auto-merge
October 28, 2026 14:14
shreyas-goenka
approved these changes
Oct 28, 2026
| // the dynamic tree, which still holds the patterns, followed by the include sections | ||
| // of included files (merging concatenates sequences). Those are kept as they are. | ||
| // Include is omitempty, so an empty list is absent from the configuration. | ||
| b.Config.Include = append(files, b.Config.Include[len(patterns):]...) |
Contributor
There was a problem hiding this comment.
why not b.Config.Include = files? Seems like a noops to append b.Config.Include[len(patterns):]
| } | ||
|
|
||
| vs = append(vs, v...) | ||
| expanded = append(expanded, withPath(filepath.ToSlash(m))) |
Contributor
There was a problem hiding this comment.
Small regression in that we do loose the location metadata for these fields?
andrewnester
approved these changes
Oct 28, 2026
Collaborator
Integration test reportCommit: d3e5dde
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Four mutators now read and edit the typed config directly instead of going through
b.Config.Mutate:PrependWorkspacePrefix: theworkspace.*_pathfields.ApplyBundlePermissions: thepermissionsfield of each supported resource.ProcessStaticResources: lists resource keys from the typedResources.ProcessRootIncludes: writes the expanded include list after the included files are merged, because merging reloads the typed config from the dynamic tree.Split out of #7098.
Why
This is a step toward removing
dynfrom the mutator pipeline. Mutators that edit typed config are simpler and don't need to convert between the two forms.Intentional behavior notes
in databricks.yml:L:C). Before,ApplyBundlePermissionsrebuilt the permissions without locations. One golden changed because of this.ApplyBundlePermissionsnow walks resource names in sorted order. This only changes the order of overlap warnings.ExpandPipelineGlobPathsstays on the dynamic tree: with a typed edit the libraries that a glob expands to lose its location, because locations are attached by index when the typed config is converted back.Tests
TestAccept/bundlesuite ran locally. The only golden diff is the one invalidate/secret_scope_invalid_permission_level.This pull request and its description were written by Isaac.