Repository navigation
manifest: add loong64 to manifest annotate, and remove hard-coded os/arch list in validation - #7448
Merged
Merged
Conversation
thaJeztah
added
impact/changelog
status/2-code-review
kind/bugfix
Signed-off-by: 吴小白 <296015668@qq.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Replace the hardcoded list of supported OS/architecture combinations with syntax validation using containerd/platforms. This allows annotating manifests with platforms that are not explicitly known to the CLI, while still rejecting missing or malformed values. The validation uses a FormatAll/Parse roundtrip until containerd/platforms provides a dedicated validation function. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Oct 30, 2026
thaJeztah
commented
Oct 30, 2026
Comment on lines
+143
to
+146
| // Validate platform syntax, without restricting OS/architecture combinations. | ||
| // | ||
| // TODO(thaJeztah): Implement a platforms.Validate in containerd/platforms and replace this code. | ||
| p := imageManifest.Descriptor.Platform |
Member
Author
There was a problem hiding this comment.
Also opened two PRs in containerd/platforms to provide some basic validation;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker manifest annotatedoes not supportlinux/loong64#7446manifest: add loong64 to manifest annotation and bash completion
manifest: validate platform syntax instead of known OS/arch combinations
Replace the hardcoded list of supported OS/architecture combinations with
syntax validation using containerd/platforms.
This allows annotating manifests with platforms that are not explicitly
known to the CLI, while still rejecting missing or malformed values.
The validation uses a FormatAll/Parse roundtrip until containerd/platforms
provides a dedicated validation function.
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)