Repository navigation
Temporarily disable flame.test for material_ui 1.8.0 - #508
Merged
Merged
Conversation
b-luk
approved these changes
Oct 20, 2026
Closed
6 tasks done
bkonyi
pushed a commit
to bkonyi/flutter
that referenced
this pull request
Oct 20, 2026
Rolls `flutter/tests` to flutter/tests#508 (`1732eab79f73fe0b9b6ead6030437c74bebd1b2e`), which temporarily disables `registry/flame.test` after `material_ui` 1.8.0 (flutter/packages#13161) enabled route-transition raster snapshotting in `FadeForwardsPageTransitionsBuilder`. Example CI failures: - https://ci.chromium.org/b/8667404745333857041 - https://ci.chromium.org/b/8667406041351366033 Part of flutter#194883
auto-submit Bot
pushed a commit
that referenced
this pull request
Oct 21, 2026
Follow-up to #508. flame-engine/flame#4125 (`69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`) updated `game_widget_lifecycle_test.dart` in `flame-engine/flame` to disable route-transition snapshotting (`FadeForwardsPageTransitionsBuilder(allowSnapshotting: false)`) for `material_ui` 1.8.0. This re-enables `registry/flame.test` and updates the pinned `flame` revision to `69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`. Part of flutter/flutter#194883
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Oct 22, 2026
Rolls `flutter/tests` to flutter/tests#508 (`1732eab79f73fe0b9b6ead6030437c74bebd1b2e`), which temporarily disables `registry/flame.test` after `material_ui` 1.8.0 (flutter/packages#13161) enabled route-transition raster snapshotting in `FadeForwardsPageTransitionsBuilder`. Example CI failures: - https://ci.chromium.org/b/8667404745333857041 - https://ci.chromium.org/b/8667406041351366033 Part of flutter#194883
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
material_ui1.8.0 (flutter/packages#13161) enabled route-transition raster snapshotting (allowSnapshotting = true) inFadeForwardsPageTransitionsBuilder, causinggame_widget_lifecycle_test.dartinflame.testto fail becauseSnapshotWidgetreuses the cached route raster instead of callingGameRenderBox.painta second time during the transition.Example CI failures:
This temporarily disables
flame.testto unblock theflutter/fluttertree while flame-engine/flame#4125 lands.Part of flutter/flutter#194883