Repository navigation
listenHTTP: bind to the given host, localhost by default - #199
Merged
filippi merged 2 commits intoOct 21, 2026
Merged
Conversation
Collaborator
Author
Also adding a warning
|
filippi
approved these changes
Oct 21, 2026
filippi
left a comment
filippi
left a comment
Contributor
There was a problem hiding this comment.
good ! was fun to kaunch command from the bronwser but yes, very unsafe
Collaborator
|
There are still other issues to solve with the HTTP, I sent them to Antonio, such as the Docker is being currently bricked. WASM is probably the safe path for browser-based interactions, as it wouldn't open any port. |
filippi
pushed a commit
that referenced
this pull request
Oct 21, 2026
Bind inside Docker with listenHTTP[0.0.0.0:8000] in the docs, treat an empty host as localhost, write the real hostname to httpConnectInfo.txt on 0.0.0.0, close the socket when bind fails, restore remoteCommand and cout on exceptions, and refuse commands from another site or host name. Thanks @HugoFara for the review.
antonio-leblanc
added a commit
that referenced
this pull request
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listenHTTP[]now binds tolocalhostby default and to the host given inlistenHTTP[host:port]; any other interface prints a warning, andlistenHTTP[0.0.0.0:8000]restores the old behaviour.systemExecis refused over HTTP, and the file server no longer follows..or absolute paths.listenHTTP[host=127.0.0.1:8080](used intests/mnh_real_nested) keeps working.Reported by @HugoFara.