Repository navigation
fix(importer): track REST Last-Modified header separately from LastUpdated - #6306
Merged
another-rex merged 1 commit intoNov 5, 2026
Merged
Conversation
another-rex
force-pushed
the
fix-rest-head-last-modified
branch
3 times, most recently
from
November 4, 2026 22:50
f2f4cdf to
963e36b
Compare
another-rex
marked this pull request as ready for review
November 4, 2026 23:04
another-rex
force-pushed
the
fix-rest-head-last-modified
branch
from
November 4, 2026 23:08
963e36b to
1b6c27d
Compare
michaelkedar
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REST
all.jsonendpoints have HTTPLast-Modifiedheader reflecting when the index file was built and uploaded. which is (generally) slightly later than the maximummodifiedtimestamp in actual entries.Because
handleImportRESTsetsLastUpdated(last_update_date) tomin(timeOfRun, maxModified, httpLastModified),LastUpdatedends up strictly earlier than theLast-Modifiedheader.This means we never actually save on any GET requests when we send a HEAD request.
Changes
This adds a new SourceRepository field into the datastore saving the HTTP REST LastModified header. (This will need to be migrated to sql at some point).
agy