Repository navigation
0.3.9 live-test lane: frontdoor resume de-chunk, Bedrock throttling ≠ overflow, silent file clicks, stale question cards, stdout log, activity colors - #1871
Merged
Conversation
…boundaries 83cd8af made the resume path de-chunk the engine dial unconditionally and discard each read's unconsumed tail. Two consequences: - an identity-encoded body (the frontdoor suite's HTTP/1.0 fakes) was fed to the chunk parser, which consumed nothing, so every gap/live frame was dropped. 4 TestSourceSideSequencing cases failed deterministically since 83cd8af, and deploy-gate.sh has been red on main. - for real chunked bodies, a chunk-size line or a chunk-closing CRLF split across reads was dropped/misparsed, wedging that member's stream. De-chunk only when the dial head says Transfer-Encoding: chunked, carry the pending tail into the next read, and consume the chunk-closing CRLF in its own state. New TestResumeDechunk feeds a chunked body at every read size. Full frontdoor suite: 64/65 (test_stalled_member_drop... is an order-dependent flake, 3/3 alone).
…as context overflow
Bedrock ThrottlingException messages (e.g. 'Token throughput limit exceeded',
'Too many tokens per minute') match the broad regex patterns in isContextOverflow
(specifically /token limit exceeded/i, /too many tokens/i, /exceeds the limit of/i)
and are misclassified as context-window overflow. This triggers the compaction
recovery path, which also fails (same throttle), producing a misleading
'Conversation history too large to compact' error.
The misclassification is amplified by the Bedrock AI SDK adapter's known quirk of
coercing undefined to the string 'undefined' — the message() function in
provider/error.ts correctly extracts the real error from responseBody, but strips
the SDK's '429 Too Many Requests' prefix that would have triggered the 'too many
requests' exclusion.
Three fixes:
1. Status code guard in parseAPICallError: HTTP 429 and 5xx are never context
overflow regardless of message text. This is the highest-leverage fix — every
Bedrock throttling error arriving as HTTP 429 is now immune.
2. Tighter isContextOverflow patterns + broader exclusions:
- /exceeds the limit of/ now requires a context/input/prompt noun prefix
- New exclusions for 'throughput', 'per minute/second/hour/day',
'invocation.*limit/quota', and 'quota'
3. Tests for Bedrock throttling messages that must NOT be classified as context
overflow, covering both the pattern-level check and the full APICallError
parsing path (including the 'undefined' message workaround).
(cherry picked from commit 4e7a41f)
…avoid misclassifying quota limits (cherry picked from commit 34e910a)
…ute handlers off stdout (#1834)
…text and stale-path refusals; a throwing context callback cannot swallow the click (#1845)
… request-not-found replies (#1754)
…marketplace and the unpublished 0.3.8)
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
…on (port of harmoniqs/opencode#379, #378) Ported from the fork branch amico/issue-378-activity-colors (df38ec003c) into the app-bundle overlay. The fork-side edits to run-view/device-view/ calibration-view are dropped: amicode removed those surfaces (#1818, pinned by research-surfaces-absence.test). status-popover-body keeps the engine toggle's engine-state dot and uses ActivityDot for real MCP servers. app/ui typecheck clean; app unit suite matches the lane baseline (24 pre-existing failures, zero new); activity + tab-status + widget-frame tests green.
aarontrowbridge
changed the title
Member
Author
|
Added f2114a1: the activity color system (port of harmoniqs/opencode#379, closes #378 there): blue running, amber attention, shared ActivityDot. app/ui typecheck clean; app unit suite matches the lane baseline (24 pre-existing failures, 0 new). Deploy gate green. Deployed: app dist |
…#0a84ff light, #4da3ff dark) and a halo pulse instead of fading the dot to 35%
…on ::after (the color-mix box-shadow keyframe minified to empty)
This was referenced Oct 25, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live-test lane for the next release. It's deployed to the fleet (erlich) for live testing before merge: frontdoor, app dist and engine binary
dcd478d5(shard 1 now, shards 2/3 roll automatically when idle), plus the macbook extension0.3.9-lane.1.Contents (main@163d100f +):
83cd8afc)console.logfrom stdout, plus a test that pins route handlers off stdoutsession.error) retires the session's question/permission cards, so no more "request not found" replies to dead turns0.3.9-lane.1(above the marketplace, so the auto-updater can't clobber it). Set the real release version before tagging.Gates:
deploy-gate.sh --scope engine --staged-binaryis GREEN (frontdoor suite, jev, drift, engine typecheck, full engine test lane with zero new failures, boot smoke). New tests for each fix fail on main and pass here.Live checks done so far: Bedrock (Opus) prompt plus a task subagent round-trip on the new engine; an
auth.jsonwrite reaches the running engine without a restart (dummy key added, then removed). Pending: panel reload on the macbook (file click, question cards, reattach, picker).Observed after the frontdoor restart: 10
resume member dropped — stalled (queue full)lines over ~30s on shard 2's catch-up, thenmigrated to shared fan-outand stable. Watching.Supersedes #1858 and #1386 once merged. Fixes #1834, #1845, #1754.