Repository navigation
feat(app): unify activity status colors — blue running, amber attention - #379
aarontrowbridge wants to merge 1 commit into
Conversation
One activity vocabulary (--activity-{idle,running,attention,success,error}
plus -soft fills) aliasing the v2 state tokens replaces the raw-hex
--status-* tokens. Session tab status gains an attention state
(error > attention > running > unread > idle) shared by the tab strip,
sessions dropdown, home and sidebar. Run, connection, MCP, LSP, server,
vault and devtools dots map onto the same roles, carry accessible
labels, and share one reduced-motion-aware pulse. Yellow no longer
encodes any state.
Refs #378
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
…on (port of harmoniqs/opencode#379, #378) Ported from the fork branch amico/issue-378-activity-colors (df38ec003c) into the app-bundle overlay. The fork-side edits to run-view/device-view/ calibration-view are dropped: amicode removed those surfaces (#1818, pinned by research-surfaces-absence.test). status-popover-body keeps the engine toggle's engine-state dot and uses ActivityDot for real MCP servers. app/ui typecheck clean; app unit suite matches the lane baseline (24 pre-existing failures, zero new); activity + tab-status + widget-frame tests green.
|
Ported into amicode's app-bundle overlay on the 0.3.9 live-test lane (harmoniqs/amicode#1871, commit f2114a16) and deployed to the fleet. The run-view/device-view/calibration-view hunks were dropped because amicode removed those surfaces (#1818). The red typecheck and preview checks here are runner-environment failures (tree-sitter-powershell install script; Playwright doesn't support ubuntu26.04), not the change. The fork is archived for engine development, so this PR can close once #1871 merges. |
|
Ported into amicode and shipped in v0.3.9 (harmoniqs/amicode#1871). |
Closes #378
What
Every activity/status surface now draws from one semantic token layer (
--activity-*indesign-polish.css, aliasing the theme's--v2-state-*), with canonical associations:#3250df#7698fd#d97706#fbbf24Yellow never encodes a state. Amico presence (harmonic dot, lane, wave, mark) is untouched.
Notable behavior changes
attentiontab state (precedence error > attention > running > unread > idle) instead of green "done"; the sidebar now uses the same derivation.pendingnow has a color.ActivityDot(role=img + aria-label) replaces color-only dots in connections, MCP/LSP, server, vault rows.TONE_DOTand.amc-livedot/.amc-entity-dot, and two duplicate pulse keyframes. Widget frame accent default#FFF676→#FFE614.packages/app/CONTEXT.md.Verification (run by the director in the worktree)
bun test --conditions=solid --preload ./happydom.ts ./src: 1195 pass / 0 fail (session-tab-status 9/9, 4 red before)bun test src: 509 pass / 0 fail (newactivity.test.ts16)bun test --conditions=browser src: 422 pass / 0 failamicode-widget-frame.test.ts: 5 passbun typecheckclean in app, ui, session-ui, opencodeNot yet done: eyeball check of both themes in the running app — please look at the tab strip, sidebar, status popover, and run view before merging.