Repository navigation
Conversation
This was referenced Oct 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #300, which is stacked on #299 and the rc4 pin in #298. Hold until #298 merges. Replaces #276.
The parsing is in lambda-feedback/lambda-feedback-packages#13.
<,<=,>,>=and!=(and≠,≤,≥) now parse to SymPy relations.1 < x < 5parses to anAndof two relations. Grading, feedback, preview and docs stay here.Behaviour (unchanged from #276)
2x - 10 >= 0x >= 5,5 <= x,4x - 20 >= 0,10 - 2x <= 0x > 5(strictness),x <= 5(opposite direction)1 < x < 55 > x > 1,0 < x - 1 < 4,2 < 2x < 101 <= x < 5(strictness)x != 55 != x,2x != 10,x - 5 != 0,x ≠ 5x = 5Where it goes
app/context/symbolic/inequalities.py:inequality_boundsandcheck_inequality_equivalence, along with the single, chained and!=helpers. The result is anInequalityComparisonenum, and each member's name is the criterion tag suffix (_TRUE,_WRONG_DIRECTION,_STRICTNESS_MISMATCH, ...). This replaces Support inequalities in the answer and response #276's mix of True/False/None/str and its result-to-tag dict. Support inequalities in the answer and response #276's bareexcept Exceptionis nowexcept TypeError.check_equality(app/context/symbolic/comparison.py): relations are caught before thelhs - rhssubtraction, which raised aTypeErroron them.app/context/symbolic/graphs/equivalence.py:add_inequality_equivalence_nodes.criterion_equality_nodeuses it after set equivalence and before equalities.app/feedback/symbolic.py: the seven newINTERNALstrings.app/preview/symbolic.py: the response is split only on a lone=, sox >= 5andx != 5preview as one relation.app/docs/user.mdandapp/docs/dev.md.Not changed:
check_orderstill subtractslhs - rhswithout a guard. #276 didn't touch it either.Tests
symbolic_evaluation_test.py, and its preview test intosymbolic_preview_test.py. The parser tests are in packages#13.test_radians_to_frequency, which fails before this PR too. The twoa!=bfactorial cases that fail on Pin the packages to the rc4 preview #298–Add significant figures and decimal places parameters #300 now pass.check_equalitycomplexity rises to 13, and_compare_single_inequalityis 13.🤖 Generated with Claude Code