Repository navigation
Revert "Place a GPX along a video without GPS by its creation time" (#940) - #946
Merged
Merged
Conversation
…apillary#940) This reverts the merge of mapillary#940 (3fcf6ca), back to main as it was after mapillary#939. mapillary#940 placed a GPX track along a video without GPS timestamps by the video's creation time. It was decided, after mapillary#940 was opened, that the creation time, which comes from the camera's clock, is never to be used to place a track: only a video's own GPS timestamps and its duration are. mapillary#944 handles videos without GPS timestamps that way instead, warning when the video and the track differ in length, and is stacked on mapillary#939, so it applies once mapillary#940 is reverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #940, back to main as it was after #939: the tree is identical to that of d597d3a.
#940 placed a GPX track along a video without GPS timestamps by the video's creation time. It was decided, after #940 was opened, that the creation time, which comes from the camera's clock, is never to be used to place a track: only a video's own GPS timestamps and its duration are. #944 handles videos without GPS timestamps that way instead, warning when the video and the track differ in length. It is stacked on #939, and it and #945 apply cleanly once this is merged.
#938 and #939 are not affected.