Repository navigation
Conversation
## Motivation and Context The null id test of `test/mcp/server_test.rb` (modelcontextprotocol#612) expects the refusal to carry `"id": null`, and the test of an id that is neither a string nor an integer (modelcontextprotocol#613) only checks that `response[:id]` is nil. modelcontextprotocol#615, merged after both, leaves the `id` member out of an error response whose request id cannot be read, so the first test fails on main (CI run 39142457575) and the second no longer pins the shape of the response. Both now expect a response without an `id` member; the library is unchanged. ## How Has This Been Tested? `test/mcp/server_test.rb`; against main the null id test fails as in CI.
atesgoral
approved these changes
Oct 18, 2026
koic
deleted the
expect_no_id_in_the_refusal_of_an_unreadable_request_id
branch
October 18, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The null id test of
test/mcp/server_test.rb(#612) expects the refusal to carry"id": null, and the test of an id that is neither a string nor an integer (#613) only checks thatresponse[:id]is nil. #615, merged after both, leaves theidmember out of an error response whose request id cannot be read, so the first test fails on main (CI run 39142457575) and the second no longer pins the shape of the response. Both now expect a response without anidmember; the library is unchanged.How Has This Been Tested?
test/mcp/server_test.rb; against main the null id test fails as in CI.Checklist