Skip to content

Expect no id in the refusal of an unreadable request id #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koic merged 1 commit into from
Oct 18, 2026
+2 −2
Merged

Expect no id in the refusal of an unreadable request id #622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/mcp/server_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1942,7 +1942,7 @@ def read_resource_request(uri)

response = @server.handle({ jsonrpc: "2.0", id: nil, method: "tools/call", params: { name: "count", arguments: {} } })

assert_equal({ jsonrpc: "2.0", id: nil, error: { code: -32600, message: "Invalid Request", data: "Request ID must not be null" } }, response)
assert_equal({ jsonrpc: "2.0", error: { code: -32600, message: "Invalid Request", data: "Request ID must not be null" } }, response)
assert_equal 0, calls
end

Expand Down Expand Up @@ -1996,7 +1996,7 @@ def read_resource_request(uri)
[3.14, true, false, { a: 1 }, [1]].each do |id|
response = @server.handle({ jsonrpc: "2.0", id: id, method: "ping" })

assert_nil response[:id], id.inspect
refute response.key?(:id), id.inspect
assert_equal(-32600, response[:error][:code], id.inspect)
end
end
Expand Down
Loading