Repository navigation
Conversation
… flaky due to configuring its failpoint through a client with timeout options
Open
3 of 5 tasks
NoahStapp
marked this pull request as ready for review
October 29, 2026 15:16
NoahStapp
requested review from
aclark4life
and
a balanced review from Copilot
October 29, 2026 15:16
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change isolating failpoint setup from the timeout-configured test client.
No open issues 🎉
What changed in this PR
Reduces flakiness in the transactions unified test by separating failpoint configuration from the client with timeout options.
Changes:
- Adds a dedicated
failPointClientwithuseMultipleMongosesdisabled. - Uses that client to configure the failpoint instead of
client0.
| File | Description |
|---|---|
test/transactions/unified/error-labels-blockConnection.json |
Isolates failpoint setup from the timeout-configured test client. |
Review effort: Balanced
aclark4life
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… flaky due to configuring its failpoint through a client with timeout options
PYTHON-6123
Changes in this PR
Implements DRIVERS-3659.
Test Plan
Existing test changes.
Checklist
Checklist for Author
Checklist for Reviewer