Repository navigation
fix(web): a ~\ home path opens as a read-only home file, not as a project file - #38510
juliusmarminge merged 5 commits into
Conversation
Match the server's home-path expansion so edits cannot save home-file content into a different file under the project. Build breadcrumbs using the workspace path style, preserving literal backslashes on POSIX.
Use the smaller home-prefix fix selected in review. Keep relative-path backslashes literal and use the same spelling in all breadcrumb helpers.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Home paths beginning with ~\ now receive the same read-only treatment and home breadcrumbs as ~/ paths. Server access is unchanged, and the fix prevents these files from being treated as editable project files. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
…overs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The folder browser navigates ~/ but not ~\ home paths, so treating a pasted ~\ path (or a ~\ base-directory setting) as a replacement left the Add project palette out of browse mode. Folder boxes keep main's handling; only the file panel reads ~\ as a home path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EvidenceEnvironment on both sides: Chromium 156, Linux web client, 1280×800, light theme, fresh isolated databases, synthetic files and replay provider. Steps: create a home NOTES.md containing
Recordings omit startup loading, play at quarter speed with a two-second pause on the disk result, and mask the brief initial shell prompt to keep internal paths private. File content, editing/save interaction and disk-check output remain visible. Scenario and seed/verification driver, uploaded without committing it. Not shown:
|
**v0.1.11-nightly.20261118.4890** · 35 changes from 19 contributors - **Thread-aware terminals.** Run thread-aware commands from integrated terminals without specifying the thread. - **Antigravity sign-in.** Sign in to Antigravity on servers without a graphical display. - **Antigravity turns.** Antigravity threads can complete turns without failing during initialization. ### Plus 31 more bug fixes. <details> <summary>Full changelog</summary> ## What's Changed * fix(server): label Copilot rg calls as file searches by @amv146 in pingdotgg/t3code#38512 * fix(web): keep Ready pending label until its request finishes by @Yash-Singh1 in pingdotgg/t3code#38517 * fix(azure-devops): issue lists reuse each project's states and survive a refresh while loading by @juliusmarminge in pingdotgg/t3code#38508 * fix(acp): Devin terminals no longer inherit the launching thread's T3 MCP credentials by @ianrowe12 in pingdotgg/t3code#26652 * fix(web): a ~\ home path opens as a read-only home file, not as a project file by @SouthCarpet in pingdotgg/t3code#38510 * fix(web): thread jump hints re-check when a modifier changes while the hold is already met by @juliusmarminge in pingdotgg/t3code#38545 * fix(server): Changes base follows the remote a plain recorded base branch tracks by @juliusmarminge in pingdotgg/t3code#38543 * fix(web): the issue viewer shows why a refresh failed by @StiensWout in pingdotgg/t3code#38537 * fix(shared): Latin letters such as ł, ø, þ and ı no longer split words in generated folder and branch names by @SouthCarpet in pingdotgg/t3code#38540 * fix(server): steering a running turn carries MCP app model context by @juliusmarminge in pingdotgg/t3code#38554 * fix(web): thread details rows no longer show stray scrollbars on touch screens by @tris203 in pingdotgg/t3code#38546 * fix(web): very wide or tall lone images in user messages show the whole image by @juliusmarminge in pingdotgg/t3code#38558 * fix(mobile): a retried document upload keeps its tile and shows progress by @StiensWout in pingdotgg/t3code#38553 * fix(client-runtime): closed issue searches no longer build up in memory by @StiensWout in pingdotgg/t3code#38493 * fix(acp-registry): each Mistral Vibe model shows its own thinking levels by @amtiYo in pingdotgg/t3code#38556 * fix(server): Cursor history on large accounts loads in pieces and keeps what was read by @juliusmarminge in pingdotgg/t3code#38567 * fix(web): idle numbered terminals show their name in the app language by @StiensWout in pingdotgg/t3code#38565 * fix(server): the first message on an imported conversation sends its history once by @juliusmarminge in pingdotgg/t3code#38575 * fix(pi): worktree handoff no longer leaves Pi threads Waiting by @juliusmarminge in pingdotgg/t3code#38582 * fix(mobile): use the shared rounded frame for issue details by @PixPMusic in pingdotgg/t3code#38491 * fix(server): an Antigravity update refreshes every instance's model list by @sittingmongoose in pingdotgg/t3code#36035 * test(release): release smoke refreshes the committed lockfile instead of resolving every package fresh by @juliusmarminge in pingdotgg/t3code#38592 * fix(server): Antigravity turns no longer fail on a roots notification to the T3 MCP server by @Bert0ns in pingdotgg/t3code#36439 * fix(server): Antigravity 1.5 asks for sign-in when it cannot open a browser by @sittingmongoose in pingdotgg/t3code#36037 * fix(server): integrated terminals get T3CODE_THREAD_ID like agent sessions by @frankhommers in pingdotgg/t3code#35006 * fix(antigravity): thread sessions spawn with their T3 thread and MCP environment by @marsidev in pingdotgg/t3code#36495 * fix(server): server preview tabs opened at startup no longer stay loading by @Kenmege in pingdotgg/t3code#37406 * fix(server): a Claude command moved to the background keeps its command in Background work by @josephv123 in pingdotgg/t3code#37787 * fix(server): restart note says how to resume a cut Claude subagent by @0xpolarzero in pingdotgg/t3code#37266 * fix(server): preserve explicit document breaks in RTF attachment text by @Lucenx9 in pingdotgg/t3code#38598 * fix(server): preserve raw notebook cell labels in attachment text by @Lucenx9 in pingdotgg/t3code#38612 * fix(server): Hermes Agent's reply after a background process finishes reaches the thread by @juliusmarminge in pingdotgg/t3code#38615 * fix(server): Claude text generation sends attached images by @juliusmarminge in pingdotgg/t3code#38619 * fix(server): RTF tracked deletions are left out of the extracted text by @Marve10s in pingdotgg/t3code#38605 * fix(server): a finished run no longer keeps an unused file index alive by @antoniooo12 in pingdotgg/t3code#38585 ## New Contributors * @amtiYo made their first contribution in pingdotgg/t3code#38556 * @sittingmongoose made their first contribution in pingdotgg/t3code#36035 * @Bert0ns made their first contribution in pingdotgg/t3code#36439 * @marsidev made their first contribution in pingdotgg/t3code#36495 * @Kenmege made their first contribution in pingdotgg/t3code#37406 * @0xpolarzero made their first contribution in pingdotgg/t3code#37266 * @antoniooo12 made their first contribution in pingdotgg/t3code#38585 **Full Changelog**: pingdotgg/t3code@v0.1.11-nightly.20261118.4877...v0.1.11-nightly.20261118.4890 </details> Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.11-nightly.20261118.4890








Problem
The server reads a file path that starts with
~\from the home folder, the same as~/. The web client treats only~/as a path outside the project. So a file that is opened by a~\path shows the home file, but the panel handles it as a project file: the breadcrumbs start with the project, the editor accepts typing, and a save writes another file under the project.Example on Windows, in a project named
r3whose home file.claude/CLAUDE.mdholds# Notes:@~\.claude/CLAUDE.mdand a space into the composer of a project thread. A file chip appears.# Notes, read from the home folder.Edited in previewand press Ctrl+S.r3,~\.claude,CLAUDE.md, and the save makes the new file<project>/~/.claude/CLAUDE.mdwithEdited in preview# Notes. The home file still holds# Notes. No message tells the user.~,.claude,CLAUDE.mdand the file is read-only, as for~/.claude/CLAUDE.md.The same cause has more effects:
~\.claude/CLAUDE.mdin the file panelr3,~\.claude,CLAUDE.md; editable~,.claude,CLAUDE.md; read-only~\.claude\CLAUDE.mdin the file panel~,.claude\CLAUDE.md; read-only~/~\folder\ childin a folder field (a path pasted after~/)~/~\folder\ child~\folder\ childChange
Two source files, 9 lines added and 5 removed:
packages/shared/src/path.ts:isHostPathis true for the prefix~\too. The existing rule of the file panel then makes the file read-only.packages/shared/src/path.ts:resolvePastedPathkeeps the backslashes of a~\path, as it does for a Windows path. Without this, the widerisHostPathwould read a backslash before a space as a shell escape and give~\folder child.apps/web/src/components/files/filePath.ts:fileBreadcrumbsreads a leading~\as~/. The rest of the path is split as before.The server does not change.
Scope
A small fix of an obvious bug, so it has no issue: the client now follows the read that the server does already. The server side came with #29378 (merged, no linked issue; commit
f52e5c1919, on main, committed 2026-11-14 14:38:02 UTC), and its test inapps/server/src/workspace/WorkspaceFileSystem.test.tsexpects that~\.claude/CLAUDE.mdis read from the home folder. Issue #35058 was closed as not planned with the statement that a file outside the project is read-only on purpose.Not covered by this pull request:
~,.claude\CLAUDE.md), on every platform. A relative path with backslashes is shown the same way today (dir\one/report.txtgivesdir\one,report.txt). The file is read from the home folder and is read-only; only the crumb for the folder.claudeis missing.~\\gives~,\, and~\.claude\gives~,.claude\.~\path. Its start value for~\projectschanges from~/~\projects\to~\projects\, and neither value lists the folder.~\path under the project. This change stops the client from offering the edit; it does not change the write.Related open pull requests:
fileBreadcrumbs. Both change the same lines offileBreadcrumbs, so the second to merge resolves a conflict. It does not changeisHostPath.isHostPathorfileBreadcrumbs.Verification
isHostPathand one new row in the existingresolvePastedPathtable (packages/shared/src/path.test.ts, 64 passed), and one assertion in the existing home-breadcrumb case (apps/web/src/components/files/filePath.test.ts, 22 passed).vp run check:changed ecb295516fb1a7a606e31778b14bf2c58dd4cc41 --concurrency 1: all steps pass (format, lint, knip, typecheck of 36 packages, 88 tests in 3 test files).~user\notes.md,~alone anddir\one/report.txtstay project paths;~/,C:\Temp\x.md,\\server\share\x.mdand/tmp/x.mdgive the same crumbs as before.Not tested:
Evidence
Desktop app from source on both sides, one isolated home (made for the before run and reused for the after run), light theme, content area 1280x800, one demo project
r3with aREADME.md. A real paste of the mention into the composer, then a click on the chip. No message was sent. On the base, typing the same mention one character at a time made no chip; the chip came from the paste.ecb295516f(on main, committed 2026-11-17 12:37:38 UTC)1fbd6b76cb~\.claude/CLAUDE.mdr3,~\.claude,CLAUDE.md~,.claude,CLAUDE.md# Notes# NotesREADME.mdand the new~/.claude/CLAUDE.mdwithEdited in preview# NotesREADME.mdonlyBefore, the panel after the click on the chip:
After, the same action:
After, the path with only backslashes (
~\.claude\CLAUDE.md), the limit that "Not covered" names:The after captures reuse the app profile of an earlier after run, so they show a draft entry in the sidebar and a "Stash 1" button above the composer that the before capture does not have.
Not shown:
vp run scenarios:prove.gpt-6.1-sol on T3 Code wrote the fix and the tests. claude-opus-5-5 on T3 Code verified both.