Repository navigation
test: fail CKMSQuantiles test if nothing throws - #2649
Merged
zeitlinger merged 1 commit intoNov 6, 2026
Merged
Conversation
The message checks sat in catch blocks with no fail() after the call, so the test passed even if Quantile stopped rejecting its arguments. Signed-off-by: Sharang Gupta <sharang@sharanggupta.dev>
sharanggupta
requested review from
dhoard,
fstab,
jaydeluca and
zeitlinger
as code owners
November 4, 2026 22:12
zeitlinger
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CKMSQuantilesTest.testIllegalArgumentExceptionchecked the messages only in catch blocks with nofail()after the calls, so it passed even ifQuantilestopped rejecting out-of-range arguments. It now usesassertThatExceptionOfType, like the other tests in the module.