Skip to content

test: fail CKMSQuantiles test if nothing throws #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeitlinger merged 1 commit into from
Nov 6, 2026
Merged

test: fail CKMSQuantiles test if nothing throws #2649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions ...heus-metrics-core/src/test/java/io/prometheus/metrics/core/metrics/CKMSQuantilesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.prometheus.metrics.core.metrics;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.assertj.core.data.Offset.offset;

import io.prometheus.metrics.core.metrics.CKMSQuantiles.Quantile;
Expand Down Expand Up @@ -431,20 +431,12 @@ void testGetGaussian() {

@Test
void testIllegalArgumentException() {
try {
new Quantile(-1, 0);
} catch (IllegalArgumentException e) {
assertThat(e.getMessage()).isEqualTo("Quantile must be between 0 and 1");
} catch (Exception e) {
fail("Wrong exception thrown" + e);
}
try {
new Quantile(0.95, 2);
} catch (IllegalArgumentException e) {
assertThat(e.getMessage()).isEqualTo("Epsilon must be between 0 and 1");
} catch (Exception e) {
fail("Wrong exception thrown" + e);
}
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> new Quantile(-1, 0))
.withMessage("Quantile must be between 0 and 1");
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> new Quantile(0.95, 2))
.withMessage("Epsilon must be between 0 and 1");
}

private List<Double> shuffledValues(int n, Random random) {
Expand Down
Loading