Repository navigation
fix: preserve rotation quadrants in trlog2 - #256
Open
vera-rubin wants to merge 1 commit into
Open
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
petercorke
approved these changes
Oct 15, 2026
Collaborator
|
Thank you for your interest in SMTB, for the report in #252, and for the fix. It's great to have a first PR from you. I confirmed that 120°, 180° and −120° fail all three round trips ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trlog2loses the quadrant for rotations beyond 90°, so its logarithms don't exponentiate back to the input.We use
atan2in the SO(2) and SE(2) branches to recover the correct angle.We tested the reported round trips and added a regression covering matrix and twist returns alongside the existing 2D pose and twist tests.
Fixes #252
— ChipLab