Repository navigation
Render service, from #777's review: RENDER_FILES checked, contained and keyed - #778
Merged
Merged
Conversation
…nd keyed - The service refuses to start when RENDER_FILES is not a directory, rather than failing every render after the full timeout. - A link inside the folder is followed only if it stays inside it (realpath). - The cache key notes when RENDER_FILES is set, so a figure drawn from the download site is never served as one drawn from a release's files. - The route handler no longer has an unreachable branch, and its test now runs the handler and the predicate: a file is fulfilled, a missing one is a 404, a site URL is not matched. Escapes to a sibling folder and through a link are tested. - The service's header lists RENDER_FILES and RENDER_TIMEOUT; the README says what is and is not redirected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adamjohnwright
added a commit
that referenced
this pull request
Nov 2, 2026
Render service, from #778's review: RENDER_FILES checked only when started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #777 (RENDER_FILES), from its review; all of its points were low.
RENDER_FILESis not a directory, rather than failing every render after the full timeout while/healthsays the files are local. Checked by hand.realpath).RENDER_FILESis set, so a figure drawn from the download site is never served as one drawn from a release's files, nor the reverse. Keys are unchanged when it is unset.98xbeside98) and a link out of the folder.RENDER_FILESandRENDER_TIMEOUT. The README says what is and is not redirected.🤖 Generated with Claude Code