Repository navigation
Spec 001 T008: figures as large as the page allows, linked to the website - #106
Merged
Merged
Conversation
…site Measured release 98's 1,170 human diagrams, drawn by the render service from the release's files: only 7% can print their 12 px labels at 5 pt on any page; today's book has no floor and prints a median of about 1.85 pt. By the user's decision, a figure now prints as large as the page allows, in portrait or on a landscape page of its own where that is larger, never split; it links to its interactive form on the website (FR-003); and one whose labels print below 1 pt is listed in the run report. Illustrations' lettering is outlines: it is read from their PATHWAY TEXT paths at the render service's viewport scale (src/layout/lettering.ts), so they are no longer reported as unmeasured. Also from #105's review: serve's bind names the analysis gateway as a caller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adamjohnwright
added a commit
that referenced
this pull request
Nov 3, 2026
Spec 001 T008, from #106's review: the lettering reader's edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, T008 (research R4, FR-016, FR-003).
Measured. Release 98's 1,170 human diagrams, each drawn by the render service from the release's own files and placed by the layout's
measure()andplace(). None failed.event-pdffits each diagram to the portrait text width and half the page height. From the files' sizes, its labels print at a median of about 1.85 pt (inference; the book's pages were not measured).Decided (with the user, for a reader on a screen):
The rule is
FLOOR_PTand the comparison inplace(), so it is easy to change once curators have looked.Illustrations. Their lettering is outlines;
src/layout/lettering.tsreads it from thePATHWAY TEXTpaths at the render service's viewport scale, so they are no longer reported as unmeasured. Every label is about a 12 px font; the reading from the render's SVG and from the file agreed.Tests. 11 for the lettering, 6 for the links, the placement tests rewritten. Each mutant listed in tasks.md made one fail. The link was printed and read back: one annotation over the figure on its landscape page (two without the link's
inline-block). All 143 tests pass against the fixture graph.Also from #105's review:
serve's bind names the analysis gateway as its second caller.🤖 Generated with Claude Code