Repository navigation
Spec 001 T008, from #107's and #108's reviews: the lettering reader's lines, ties and markup - #109
Merged
Merged
Conversation
…ering reader Lines are the letters whose heights overlap, directly or through others, so a dot does not split one; a tie goes to the lower bottom; only a smaller box within another is a hole. The tag scan follows every element, leaves comments and character data out, reads either quotes, and leaves a label unread under a transform by style, a transformed link, a nested svg or defs. The viewport's scale, written by attribute and again by style, must agree. FR-003 names an ancestor's illustration standing in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed close tags The line and tie tests each fail now with their own fix alone undone. The scans of comments and of tags never closed are linear; a close tag ends the element it names; the viewport's class is matched whole; names are known with a prefix or in capitals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, T008 (research R4). Replaces #108, closed after its review found two tests that passed with their own fix undone. It carries #108's commit, plus:
>(a tail of<without one took 4 s).svg:defs,DEFS).#108's own changes, unchanged: lines as the letters whose heights overlap; a tie to the lower bottom; only a smaller box within another is a hole; every element followed, comments left out, either quote; a label unread under a styled or link transform, a nested
<svg>or<defs>; the viewport's attribute and style scales must agree; FR-003 names an ancestor's illustration standing in.Release 98's 221 illustrations and the sample render read exactly as before (R4's numbers stand). 160 tests pass against the fixture graph; each fix has a mutant the tests catch.
🤖 Generated with Claude Code