Skip to content

Spec 001 T008, from #107's and #108's reviews: the lettering reader's lines, ties and markup - #109

Merged
adamjohnwright merged 2 commits into
mainfrom
t008/review-3
Nov 3, 2026
Merged

adamjohnwright merged 2 commits into
mainfrom
t008/review-3

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Spec 001, T008 (research R4). Replaces #108, closed after its review found two tests that passed with their own fix undone. It carries #108's commit, plus:

  • Tests that bite: the line test has two dotted letters, so dots outvote the f on a line split off; the tie test writes the high mark first, so the letters' order cannot settle the tie. Each now fails with its own fix alone undone.
  • Linear scans: comments and character data are found with each kind's next start searched again only once passed (40,000 comments took 12 s; now under 250 ms, tested), and tags are read only up to the last > (a tail of < without one took 4 s).
  • Close tags end the element they name; a stray one ends nothing.
  • The viewport's class is matched whole, not as a prefix.
  • Element names are known with a namespace prefix or in capitals (svg:defs, DEFS).

#108's own changes, unchanged: lines as the letters whose heights overlap; a tie to the lower bottom; only a smaller box within another is a hole; every element followed, comments left out, either quote; a label unread under a styled or link transform, a nested <svg> or <defs>; the viewport's attribute and style scales must agree; FR-003 names an ancestor's illustration standing in.

Release 98's 221 illustrations and the sample render read exactly as before (R4's numbers stand). 160 tests pass against the fixture graph; each fix has a mutant the tests catch.

🤖 Generated with Claude Code

adamjohnwright and others added 2 commits November 3, 2026 04:40
…ering reader

Lines are the letters whose heights overlap, directly or through others, so a dot
does not split one; a tie goes to the lower bottom; only a smaller box within another
is a hole. The tag scan follows every element, leaves comments and character data
out, reads either quotes, and leaves a label unread under a transform by style, a
transformed link, a nested svg or defs. The viewport's scale, written by attribute
and again by style, must agree. FR-003 names an ancestor's illustration standing in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed close tags

The line and tie tests each fail now with their own fix alone undone. The scans of
comments and of tags never closed are linear; a close tag ends the element it names;
the viewport's class is matched whole; names are known with a prefix or in capitals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamjohnwright
adamjohnwright merged commit 3a6e947 into main Nov 3, 2026
2 checks passed
adamjohnwright added a commit that referenced this pull request Nov 3, 2026
Spec 001 T008, from #109's and #110's reviews: a linear tag scan, malformed markup caught
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant