Skip to content

Spec 001 T008, from #109's review: a linear tag scan, malformed markup unread - #110

Closed
adamjohnwright wants to merge 1 commit into
mainfrom
t008/review-4
Closed

adamjohnwright wants to merge 1 commit into
mainfrom
t008/review-4

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Spec 001, T008 (research R4), from #109's review. All of it concerns markup the render service does not write; it closes the cases where such markup could read wrong rather than unread, and corrects a note.

  • Linear tag scan: XML allows no < in a tag, so the tag pattern matches none. A tag left open by an unclosed quote ended only at the document's end before, from each < (4 s for 20,000); it now ends at the next <. Tested.
  • Malformed markup: a close tag that skips open elements could end the viewport and read later labels at scale 1. It now leaves every label after it unread.
  • Undrawn content: a label in a <title>, <desc> or <metadata> is unread, as one in <defs> is.
  • Notes: T008's note claimed every quadratic case was fixed by Spec 001 T008, from #107's and #108's reviews: the lettering reader's lines, ties and markup #109; it now says which one was left until this PR. R4 and the reader's comment list what is not looked for (a style element's rules, display="none", unquoted values, entities in ids, names in capitals).

Release 98's 221 illustrations and the sample render read exactly as on main (compared file by file). 162 tests pass against the fixture graph; each fix has a mutant the tests catch.

🤖 Generated with Claude Code

…p unread

XML allows no < in a tag, so none is matched: the scan is linear even with a tag left
open by an unclosed quote. A close tag that skips open elements leaves every label after
it unread; a label in a title, description or metadata is unread. T008's note no longer
overstates the earlier fix; R4 lists what is not looked for.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamjohnwright

Copy link
Copy Markdown
Contributor Author

Replaced by a new PR: its review found the notes claimed malformed markup fails safe, while a < inside an attribute value was read wrongly (unread on main).

adamjohnwright added a commit that referenced this pull request Nov 3, 2026
Spec 001 T008, from #109's and #110's reviews: a linear tag scan, malformed markup caught
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant