Repository navigation
Spec 001 T008, from #109's review: a linear tag scan, malformed markup unread - #110
Closed
adamjohnwright wants to merge 1 commit into
Closed
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
…p unread XML allows no < in a tag, so none is matched: the scan is linear even with a tag left open by an unclosed quote. A close tag that skips open elements leaves every label after it unread; a label in a title, description or metadata is unread. T008's note no longer overstates the earlier fix; R4 lists what is not looked for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by a new PR: its review found the notes claimed malformed markup fails safe, while a < inside an attribute value was read wrongly (unread on main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, T008 (research R4), from #109's review. All of it concerns markup the render service does not write; it closes the cases where such markup could read wrong rather than unread, and corrects a note.
<in a tag, so the tag pattern matches none. A tag left open by an unclosed quote ended only at the document's end before, from each<(4 s for 20,000); it now ends at the next<. Tested.<title>,<desc>or<metadata>is unread, as one in<defs>is.display="none", unquoted values, entities in ids, names in capitals).Release 98's 221 illustrations and the sample render read exactly as on main (compared file by file). 162 tests pass against the fixture graph; each fix has a mutant the tests catch.
🤖 Generated with Claude Code