Skip to content

Spec 001 T008, from #109's and #110's reviews: a linear tag scan, malformed markup caught - #111

Merged
adamjohnwright merged 2 commits into
mainfrom
t008/review-5
Nov 3, 2026
Merged

adamjohnwright merged 2 commits into
mainfrom
t008/review-5

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Spec 001, T008 (research R4). Replaces #110, closed after its review found its notes claimed malformed markup fails safe, while a < inside an attribute value was read wrongly (it was unread on main). Carries #110's commit, plus:

  • A tag not matched: excluding < from tags made a tag holding one unmatched, so its element (a transform, <defs>, the viewport itself) went unseen. A < that would begin a tag, met between matched tags, now marks the markup malformed, and no label after it is read. Tested with each of the review's four cases; the test fails with the check removed.
  • Notes narrowed: R4 and the reader's comment say what is caught (a title, description or metadata; a close tag skipping open elements; a tag holding a <) and what is not (a quote left open, a stray close tag ending the viewport itself, a style element's rules, display="none"). R4 now names desc.

From #110, unchanged: the tag pattern excludes <, so the scan is linear even with a quote left open; a close tag that skips open elements leaves later labels unread; a label in a title, description or metadata is unread.

Release 98's 221 illustrations and the sample render read exactly as on main, compared file by file, none unread. 163 tests pass against the fixture graph.

🤖 Generated with Claude Code

adamjohnwright and others added 2 commits November 3, 2026 04:52
…p unread

XML allows no < in a tag, so none is matched: the scan is linear even with a tag left
open by an unclosed quote. A close tag that skips open elements leaves every label after
it unread; a label in a title, description or metadata is unread. T008's note no longer
overstates the earlier fix; R4 lists what is not looked for.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…els unread

A tag holding a < was no longer matched, so its element went unseen and a label in it
was read wrongly. A < that would begin a tag, met between tags, now marks the markup
malformed. The notes say which malformed markup is caught and which is not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant