Repository navigation
Spec 001 T009: the analysis service's answers, measured - #112
Closed
adamjohnwright wants to merge 1 commit into
Closed
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
Against a non-production instance on release 98, with tokens the service reads by its own rules and one small analysis; nothing in its storage was touched. - The service reads a stored result first and judges a token's date (7 days, a constant in analysis-core) only when there is none: 410 within it, 404 after. A result kept longer is still answered, so pdf-export checks only the token's form, and the --retention setting is gone. - A malformed token is the service's catch-all 500, in its JSON form. - found/interactors with none is a 404, with or without interactors. - Neither the summary nor result.json carries the found count; the found identifiers' CSV does, from the same set as today's book. Also records #111's three low review findings under T008. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closed after its review: the pathways-hit count depends on includeDisease, the recorded retention is the 410 window rather than the service's cleanup, the malformed-token rule misses wrong padding and '/', and older R6 text contradicts the new. Replaced by a new PR. |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, task T009 (research R6).
Measured against a non-production instance of the analysis service on release 98, never production. Nothing in its storage was touched: each case is a token the service reads by its own rules (read from analysis-core's
TokenizerandTokenUtils), plus one small submitted analysis.What it answers (all in its JSON error form):
found/interactors/{pathway}with none found: 404, whether or not the analysis included interactors.What changes in the spec:
--retentionsetting is gone (spec edge case, contracts/service.md and cli.md, data-model, T021, T022).result.json(468 KB for four identifiers) carries the count of identifiers found. The found identifiers' CSV does, built from the same set today's book counts. T010's stub gains that CSV and a 500.The PR also records #111's three low review findings under T008.
Documents only; no code changes.
🤖 Generated with Claude Code