Repository navigation
Spec 001 T009: the analysis service's answers, measured (replaces #116) - #117
Closed
adamjohnwright wants to merge 6 commits into
Closed
adamjohnwright wants to merge 6 commits into
adamjohnwright wants to merge 6 commits into
Conversation
Against a non-production instance on release 98, with tokens the service reads by its own rules and one small analysis; nothing in its storage was touched. - The service reads a stored result first and judges a token's date (7 days, a constant in analysis-core) only when there is none: 410 within it, 404 after. A result kept longer is still answered, so pdf-export checks only the token's form, and the --retention setting is gone. - A malformed token is the service's catch-all 500, in its JSON form. - found/interactors with none is a 404, with or without interactors. - Neither the summary nor result.json carries the found count; the found identifiers' CSV does, from the same set as today's book. Also records #111's three low review findings under T008. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- pathwaysFound follows the analysis's includeDisease (229 with, 191 without here); it is asked for with includeDisease=true, as today's book counts the unfiltered list. - How long a result is kept is the service's own cleanup (by the results folder's size and last access), recorded as such; the 7 days only tell 410 from 404. - The malformed-token rule is now the form the service issues: wrong padding (QQ=) and '/' (a 400 page, or another route) were missed. - R6's older text, which contradicted the measurement, is corrected; the boundary (whole days, future-dated is 410), the time zone, the CSV's header and the help-desk placeholder are stated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s counts
- Base64 of '_' alone passed the form rule and the service fails on it
(500); the rule now also requires the decoded {14 digits}_{digits}.
- Today's book counts after its own species and resource filter, not
the stored list: recorded, with the edge for a pathway without a
p-value, left to the comparison (FR-012).
- Results are also removed outside the service's cleanup, access times
depend on the mount, and a resubmission can bring a token back.
- Spec 002: "410 for one a release deleted" corrected; whether its
report checks the token's form is left to its tasks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…unts - The token's counter is bounded to 1-19 digits (a Java long): a 7,000-digit one passed the rule and reached the servlet container's HTML 400. - Today's book counts over every species (its resource filter writes back across species); the pathways hit match pathwaysFound with includeDisease=true, and the p-value edge belongs to the identifiers count, as spec 002 already says. - A found/... 404 may mean the result went mid-PDF; T010 gains a non-JSON 400 and the right reason for its 500; the instance's ASCII dates are recorded; spec 002's paragraph and parentheses tidied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The bound is on the decoded token, so one nested in %25 layers passed the rule and, sent as given, reached the servlet container's HTML 400; pdf-export sends the canonical token (padded Base64, = as %3D). - The p-value wording agrees with spec 002's; the calendar is named beside the digits; the CSV's file name is a constant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- T020 (the analysis client) now carries T009's counts, the canonical
token and each call's Accept header: the CSV endpoint answers the
framework's own 406 to Accept: application/json alone.
- /token/{token} is paged to one pathway (1 KB, not 94 KB).
- Spec 002: its service contract's 410 row corrected, and its open item
names the canonical token and Accept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closed after its review: no test would catch a client leaving out includeDisease=true (the stub has no summary that depends on it), and later 404/410 answers are unmapped. Replaced by a new PR. |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, task T009 (research R6). This replaces #116 (and before it #112–#115), each closed after its review. Each commit after the first holds one review's fixes.
The findings are unchanged from #116. Expiry is the service's to judge, pdf-export checks only the token's form and sends the token in its canonical form, and the counts come from
pathwaysFound,identifiersNotFoundand the found identifiers' CSV.From #116's review:
Acceptheader.Acceptheader matters. The CSV endpoint answers the framework's own 406, not the service's JSON, toAccept: application/jsonalone. I re-ran this./token/{token}is now paged to one pathway: 1 KB instead of 94 KB, with the same counts (re-run);Accept.It changes documents only.
🤖 Generated with Claude Code