[zzylol]

Part of #1054 (step 8b, part 2). Merges into the integration branch refactor/stage-boundaries. Tests run for the whole branch before it merges to main.

Why

#1054's rule: an item is pub only if another crate's non-test code uses it. #1094 applied it to physical, cost, accuracy and part of asap-types. This PR applies it to the rest of asap-types, the four frontend crates and asap-planner.

What

Visibility, accessors, test-only paths and two deletions. There are no behavior changes.

Item	Change	Users
SummaryCoverage.{definition, selection}, SelectionBox, ColumnIdentity, MaterializedView.{refresh, coverage, retention_ms}, ViewCoverage, MaterializedViewInputs.raw_data_windows, RawDataWindow, RawDataRetention, PhysicalASAPDAGEdge fields, FamilyCapability.readouts	fields pub(crate); added new and accessors	only tests outside the crate. JSON is unchanged, so the DAG viewer reads the same keys
output_schema, validate_inputs, matches_node, NodeToTimedNodeCache::timed, RawDataWindow::lookback_ms, Materialization::is_materialized_view	pub(crate); tests call them through wrappers in asap_types::test_support	the crate itself, plus tests
NonASAPOp/ASAPOp children, map_children, kind_name	pub(crate)	tests use the Operator / OperatorNode versions
Schema::has_unique_key, compile_physical_asap_dag	behind test-support	tests only
frontend-common resolver items (SchemaResolver, SchemaCatalog, UsageDerivedCatalog, resolve_expr, UnresolvedScalar helpers)	pub(crate), no root re-export	only used inside the crate
frontend modules error, histogram, promql, sql, frequency, resolve, schema_resolver, unresolved	private	one public path per item
SqlLowerer; metricsql parse_metricsql, canonical_metricsql, lower_metricsql*	pub(crate); reached through each crate's test_support	tests only
asap-planner	unchanged	everything still pub is entry API that the backend uses

Deleted: HistogramCatalog::is_empty and UnresolvedOp::scalar_exprs; neither has users.

Deferred (only logical or plan-selection src/ tests read these; they are handled in P7 or #1095):

• DemandEstimate.{observed_at, valid_for}
• SupplierStorageMetrics.logical_connections
• MaintainedPopulation.{max_k, quantiles}
• CurrentSeriesInput.{metric, matchers}
• LabelSetDistinctValues fields
• Schema::lifted
• PhysicalMemoCandidates::implementation_roots

How

1. Every pub field and method in the target crates was set to pub(crate).
2. Production code was rebuilt, excluding integration-tests, and pub was restored on each item whose removal broke the build. In asap-types, 47 items survived.
3. Tests switched to accessors, ::new constructors and test_support:: paths.
4. Feature changes:
   • frontend-sql and frontend-metricsql gain test-support;
   • executor's test-support enables asap-types/test-support;
   • integration-tests enables asap-types/test-support.

Key code interfaces added / modified

The new test-only modules asap_frontend_sql::test_support and asap_frontend_metricsql::test_support, plus more wrappers in asap_types::test_support.

Usage: a test that needs lower_metricsql enables asap-frontend-metricsql/test-support in its dev-dependencies and calls asap_frontend_metricsql::test_support::lower_metricsql(..).

The private corpus's shared frontend-promql/tests/support.rs still compiles with only asap-types/test-support.

Major algorithm changes

None.

Before / After

• Before: about 390 public fields and methods in asap-types, many of them used only by tests.
• After: 47 of them are public in asap-types, because another crate's production code uses them.

Verification

At 87d769181 (on refactor/stage-boundaries after #1098):

• fmt and cargo clippy --workspace --all-targets -D warnings are clean.
• cargo build -p asap-devtools --bins and cargo check --workspace --exclude asap-integration-tests --lib --bins build with no test-support feature.
• cargo doc: no new warnings.
• Tests are not run yet. They run for the integration branch as a whole.

🤖 Generated with Claude Code

https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw