Repository navigation
feat(runner): support native Windows execution and guided onboarding - #172
AaronWangCong wants to merge 14 commits into
Conversation
|
LoopForge PR Review — head Verdict:
Missing to resolve: (1) get the @AaronWangCong could you check whether the CI run is stuck pending approval, and let us know once the Windows-side checks have results? |
|
LoopForge PR Review — head Verdict:
Missing to resolve: get the @AaronWangCong the implementation now has clean local build/vet/test evidence on both Linux and cross-compiled Windows; the only remaining gap is that CI hasn't produced any results on this SHA yet — could you check whether the |
|
LoopForge PR Review — head Verdict:
Missing to resolve: approve the pending @AaronWangCong local evidence is unchanged/clean across this increment; the only remaining gap is still CI not being allowed to run on this SHA — could you or a maintainer approve the pending workflow runs? |
main Tencent#207 added TerminalPool.HandleSandboxWithGitSSH, which runner and engine workspace preparation now call; the Windows stub lacked it, so GOOS=windows go build ./... failed after merging main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
LoopForge PR Review — head
No blocking issues found. |
|
LoopForge PR Review — head Verdict: ✅ Pass
No action needed. |
|
LoopForge PR Review — head Verdict: ✅ Pass
|
Yanami-2K
left a comment
There was a problem hiding this comment.
先留评论、不批准:代码可见部分没发现正确性问题,但有几处产品范围和合入顺序的取舍,需要维护者判断。
已核对的部分:internal/processgroup/process_windows.go 用挂起创建 + kill-on-close Job 再恢复线程,子进程在派生后代之前就已入 Job;restart_windows.go 在 Windows 上直接关闭自动更新(fail closed);archive_links_windows.go 不跟随 reparse point,获取元数据失败时中止归档;bind-cli.ps1 会校验 SHA-256 和 PE 架构,并拒绝带凭据的 ServerUrl。Windows CI(runner job)也已通过。
需要维护者确认的问题:
- Windows 服务端部署是否纳入支持范围 PR 描述写的是“The platform remains Linux-hosted”,但
docs/windows.md的“Start the platform”和新增的scripts/start-local.ps1支持在 Windows + Docker Desktop 上启动平台,README.md/README.zh-CN.md也写了“Windows users can use Docker Desktop and the PowerShell launchers”。而 #163 在同一段 README 里写的是“Windows is not supported for server deployment yet”,两者直接矛盾,可见这个产品方向还没统一。请维护者定下口径,然后和 #163 对齐。 - 范围偏大 99 个文件、+4162 行,同时包含原生 Windows Runner、Windows 平台启动脚本、独立 PowerShell 安装器、接入页 UI,以及与 Windows 无关的 CI 调整(
.github/workflows/e2e.yml和validate.yml把 Python 3.8 锁到 ubuntu-22.04、e2e-browser 锁到 ubuntu-24.04)。建议至少把 CI runner 镜像调整拆成单独的 PR,其余部分由维护者决定是否继续拆。 - 后台子进程语义与 Unix 不一致 Windows 上 root 进程退出就会杀掉整个 Job(
process_windows.go里的WaitForSingleObject协程),而 Unix 上后台子进程可以继续存活。依赖后台进程的 shell 节点(比如先启动 dev server 再由下一个节点访问)在 Windows 上会表现不同。描述里已说明,请维护者确认是否接受。 - 与 #164(x/sys 0.50.0)不冲突,但任一方先合入后,另一方应重新跑 Windows CI。
注:有大量文件的 patch 被省略,包括 internal/runner/daemon.go、detect.go、exec.go、internal/runtime/materialize_binding_windows.go、native_shell_script.go、workspace_terminal_windows.go、scripts/start-local*.ps1、web/app/runners.js 和各 Windows 测试文件,没能逐行审查。
What changed
Windows users can connect their local machine to a remotely deployed Linux platform and execute assigned SOP tasks. Previously, Unix-only process, locking and filesystem operations prevented reliable native Windows Runner execution, and the onboarding page only offered a Bash command.
Scope
Compatibility
The platform remains Linux-hosted; the native Windows Runner connects outbound to it. Shell SOP nodes require Git for Windows, project commands need their usual local tools, and Agent nodes require a supported native
.exeCLI and its configured authentication. npm batch wrappers are not advertised as native runtimes. Docker sandbox workflows still need their configured Docker environment.Windows non-interactive SOP execution and workspace operations are supported. Interactive web PTY sessions remain unsupported on Windows. Cancellation terminates the Windows process tree immediately; background descendants do not survive their parent task. Windows amd64 has live coverage; arm64 is cross-compiled. Homepage assistant and requirement clarification retain their existing server-side credential requirements.
No schema migration or Runner protocol change is required. Machine authentication and machine-card authentication-source selection retain their existing behavior. No private adapters or deployment configuration are included.
Validation
Current onboarding follow-up:
Latest follow-up
d11a33fa7bfe18458363db60dddab41aa8414abfmerges upstream main at0721241, resolves the browser endpoint conflict, and preserves Windows compatibility with the new Git lock and workspace preview code. Unix file ownership checks retain their existing behavior; Windows file URLs resolve drive paths while workspace containment still rejects outside files and junctions. UNC/device paths remain unsupported.Local verification for this follow-up passed the Windows CI package-test selection, vet, Runner/Gate builds, PowerShell 5.1/7 installer tests (9 each), 315 chatbot tests and build, 12 onboarding/access tests, and Linux runtime/API/preview regressions. The Linux bind-mount namespace case was skipped by the container environment; hardlink and ownership cases passed. Official CI for this current head passed all 17 checks: Windows Runner and PowerShell, platform core, browser, coverage and vet, E2E, and validation and secret scan.
Previous head
6fd3fe323340fbab43f33daf8d9b80f9e60852b9passed all 17 official checks, including the required gates (these are historical results, not results for the new merge):That previous head also passed all four workflows in the fork verification PR. Paid-model and external-service acceptance was not enabled.
Safety
Classic host bundles and third-party dependencies/assets are unchanged.