Repository navigation
Conversation
This was referenced Oct 25, 2026
m-messer
force-pushed
the
feat/big-operator-symbols
branch
from
October 28, 2026 13:36
54076f6 to
36c1bc8
Compare
m-messer
force-pushed
the
feat/sig-figs-decimal-places
branch
from
October 28, 2026 13:36
d56473c to
15e3a53
Compare
m-messer
force-pushed
the
feat/big-operator-symbols
branch
from
October 28, 2026 15:54
36c1bc8 to
4c58351
Compare
m-messer
force-pushed
the
feat/sig-figs-decimal-places
branch
from
October 28, 2026 15:54
15e3a53 to
8fd9210
Compare
Ports #273 and #277 onto the refactor. `sig_figs`/`significant_figures` and `dp`/`decimal_places` check the precision the response is written to, and `sig_figs_tol`/`significant_figures_tolerance` and `dp_tol`/`decimal_places_tolerance` set `rtol`/`atol`. A conflicting or out-of-range parameter raises a ValueError, and a non-integer count a TypeError. The number-string helpers come from expression_parsing (lambda-feedback-packages#12). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
m-messer
force-pushed
the
feat/big-operator-symbols
branch
from
October 28, 2026 17:48
4c58351 to
86a1678
Compare
m-messer
force-pushed
the
feat/sig-figs-decimal-places
branch
from
October 28, 2026 17:48
8fd9210 to
6079134
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #299, which is stacked on the rc4 pin in #298. Hold until #298 merges. Replaces #273 and #277.
The number-string helpers (
read_written_number,round_to_significant_figures,round_to_decimal_places) are in lambda-feedback/lambda-feedback-packages#12. Grading and docs stay here.Parameters
significant_figuressig_figs92.00≠92at 4 sf)significant_figures_tolerancesig_figs_tolrtol = 5*10**(-n); the written precision isn't checkeddecimal_placesdpsig_figs, but counts decimal places; may be 0decimal_places_tolerancedp_tolatol = 0.5*10**(-n)At most one of these, or of
atol/rtol, can be set. A conflict or an out-of-range count raises aValueError. A count that isn't anint(aboolisn't one) raises aTypeError. #277 raised a bareException; the messages are the same.Where it goes
app/evaluation.py:_apply_precision_aliasesand_apply_precision_parameters, applied in_build_parametersbefore the parsing parameters are made.sig_figsanddpgo into newEvaluationParametersfields.app/context/tolerance.py:relative_tolerance_from_sig_figsandabsolute_tolerance_from_decimal_places.app/context/symbolic/numerical.py:sig_figs_match,decimal_places_matchandmatches_written_precision.replace_pimoved out ofcompare_numericallyso both can use it.response/answercriterion,sig_figs/dpreplace the comparison, not just act as a fallback:check_equality;_quantity_match, where they replace the value comparison and units are still compared as usual._tolerancesskips the implicit tolerance from the answer when either is set.app/docs/user.mdandapp/docs/dev.md.sig_figs_tolis documented as≤, because the tolerance check here counts the boundary as within tolerance. Add decimal_places grading parameters #277's docs said<.Tests
symbolic_evaluation_test.pyandphysical_quantity_evaluation_test.py. The error tests check for the specific exception type.app/tests/precision_test.py. Dropped the cases that pass a float as the response string: the package helper only acceptsstr, and the app always passes a string.test_radians_to_frequency, and the twoa!=bfactorial cases that the Support inequalities in the answer and response #276 port fixes.check_equalitycomplexity is 11, one over the limit of 10.🤖 Generated with Claude Code