Repository navigation
Render page, from #771's review: one "not here", the reaction's analysis, tested scrubbing - #772
Merged
Merged
Conversation
…sis, tested scrubbing - isGone duplicated isNotFound and sat under describeLoadFailure's comment; one exported isNotFound now carries both comments' meaning. - The reaction view publishes analysis: null, since its layout is never coloured. - The diagram's colouring effect reads the resource itself, rather than through whatever loadAnalysis happened to read, and gives that one value to both loads, so the colouring and appliedAnalysis name the same resource. - What strips the host and analysis tokens from a failure's message is its own function, with unit tests (each rule seen failing when broken). - A new test: an analysis result the service cannot answer for (500) is reported as unread, not gone (seen failing with every error called gone). It replays the Release 97 answers already recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #771's review notes (low). No spec: a single-PR fix to the render page (#771's area).
isGoneduplicatedisNotFoundand sat underdescribeLoadFailure's comment; one exportedisNotFoundnow carries both comments' meaning.analysis: null, since its layout is never coloured.loadAnalysishappened to read, and gives that one value to both loads, so the colouring andappliedAnalysisname the same resource.render/failure-message.ts) with unit tests; each rule was seen failing when broken.Not here:
🤖 Generated with Claude Code