Skip to content

Render page, from #771's review: one "not here", the reaction's analysis, tested scrubbing - #772

Merged
adamjohnwright merged 1 commit into
mainfrom
fix/771-review-notes
Nov 2, 2026
Merged

adamjohnwright merged 1 commit into
mainfrom
fix/771-review-notes

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Follow-up to #771's review notes (low). No spec: a single-PR fix to the render page (#771's area).

  • isGone duplicated isNotFound and sat under describeLoadFailure's comment; one exported isNotFound now carries both comments' meaning.
  • The reaction view publishes analysis: null, since its layout is never coloured.
  • The diagram's colouring effect reads the resource itself, rather than through whatever loadAnalysis happened to read, and gives that one value to both loads, so the colouring and appliedAnalysis name the same resource.
  • What strips the host and analysis tokens from a failure's message is its own function (render/failure-message.ts) with unit tests; each rule was seen failing when broken.
  • New e2e test: a result the analysis service cannot answer for (500) is reported as unread, not gone. Seen failing with every error called gone. It replays the Release 97 answers already recorded.

Not here:

  • A test that the reaction view carries no analysis. It passes live, but needs two answers not recorded from Release 97, which raise two counted type-problem totals; it joins the Release 98 re-record.
  • The page's 60 s "not coloured" message is never seen behind the render service's 45 s timeout. That predates Render page: not ready until the analysis is coloured #771.

🤖 Generated with Claude Code

…sis, tested scrubbing

- isGone duplicated isNotFound and sat under describeLoadFailure's comment;
  one exported isNotFound now carries both comments' meaning.
- The reaction view publishes analysis: null, since its layout is never
  coloured.
- The diagram's colouring effect reads the resource itself, rather than
  through whatever loadAnalysis happened to read, and gives that one value
  to both loads, so the colouring and appliedAnalysis name the same resource.
- What strips the host and analysis tokens from a failure's message is its
  own function, with unit tests (each rule seen failing when broken).
- A new test: an analysis result the service cannot answer for (500) is
  reported as unread, not gone (seen failing with every error called gone).
  It replays the Release 97 answers already recorded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamjohnwright
adamjohnwright merged commit 7b63de1 into main Nov 2, 2026
14 of 15 checks passed
@adamjohnwright
adamjohnwright deleted the fix/771-review-notes branch November 2, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant